[GitHub] [hudi] garyli1019 commented on a change in pull request #2930: [HUDI-1818] Validate and check required option for HoodieTable (Azure…

2021-05-10 Thread GitBox
garyli1019 commented on a change in pull request #2930: URL: https://github.com/apache/hudi/pull/2930#discussion_r629312247 ## File path: hudi-flink/src/test/java/org/apache/hudi/table/TestHoodieTableFactory.java ## @@ -297,4 +343,4 @@ public boolean isTemporary() { ret

[GitHub] [hudi] garyli1019 commented on a change in pull request #2930: [HUDI-1818] Validate and check required option for HoodieTable (Azure…

2021-05-09 Thread GitBox
garyli1019 commented on a change in pull request #2930: URL: https://github.com/apache/hudi/pull/2930#discussion_r629008470 ## File path: hudi-flink/src/test/java/org/apache/hudi/table/TestHoodieTableFactory.java ## @@ -297,4 +343,4 @@ public boolean isTemporary() { ret

[GitHub] [hudi] garyli1019 commented on a change in pull request #2930: [HUDI-1818] Validate and check required option for HoodieTable (Azure…

2021-05-09 Thread GitBox
garyli1019 commented on a change in pull request #2930: URL: https://github.com/apache/hudi/pull/2930#discussion_r629008388 ## File path: hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableFactory.java ## @@ -98,6 +102,33 @@ public String factoryIdentifier() { // Ut