[GitHub] [hudi] guanziyue commented on a diff in pull request #9553: [HUDI-1517][HUDI-6758][HUDI-6761] Adding support for per-logfile marker to track all log files added by a commit and to assist with

2023-09-03 Thread via GitHub
guanziyue commented on code in PR #9553: URL: https://github.com/apache/hudi/pull/9553#discussion_r1314260596 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackHelper.java: ## @@ -59,18 +71,20 @@ public class BaseRollbackHelper imp

[GitHub] [hudi] guanziyue commented on a diff in pull request #9553: [HUDI-1517][HUDI-6758][HUDI-6761] Adding support for per-logfile marker to track all log files added by a commit and to assist with

2023-09-03 Thread via GitHub
guanziyue commented on code in PR #9553: URL: https://github.com/apache/hudi/pull/9553#discussion_r1314260596 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackHelper.java: ## @@ -59,18 +71,20 @@ public class BaseRollbackHelper imp

[GitHub] [hudi] guanziyue commented on a diff in pull request #9553: [HUDI-1517][HUDI-6758][HUDI-6761] Adding support for per-logfile marker to track all log files added by a commit and to assist with

2023-08-28 Thread via GitHub
guanziyue commented on code in PR #9553: URL: https://github.com/apache/hudi/pull/9553#discussion_r1308187945 ## hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFileWriteCallback.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [hudi] guanziyue commented on a diff in pull request #9553: [HUDI-1517][HUDI-6758][HUDI-6761] Adding support for per-logfile marker to track all log files added by a commit and to assist with

2023-08-28 Thread via GitHub
guanziyue commented on code in PR #9553: URL: https://github.com/apache/hudi/pull/9553#discussion_r1307822743 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/MarkerBasedRollbackStrategy.java: ## @@ -75,64 +82,115 @@ public List getRollbackR