[GitHub] [hudi] jinxing64 commented on a diff in pull request #5564: [HUDI-4087] Support dropping RO and RT table in DropHoodieTableCommand

2022-05-16 Thread GitBox
jinxing64 commented on code in PR #5564: URL: https://github.com/apache/hudi/pull/5564#discussion_r873491449 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/DropHoodieTableCommand.scala: ## @@ -69,13 +67,13 @@ extends HoodieLeafRunnabl

[GitHub] [hudi] jinxing64 commented on a diff in pull request #5564: [HUDI-4087] Support dropping RO and RT table in DropHoodieTableCommand

2022-05-15 Thread GitBox
jinxing64 commented on code in PR #5564: URL: https://github.com/apache/hudi/pull/5564#discussion_r873331963 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/DropHoodieTableCommand.scala: ## @@ -69,13 +67,13 @@ extends HoodieLeafRunnabl

[GitHub] [hudi] jinxing64 commented on a diff in pull request #5564: [HUDI-4087] Support dropping RO and RT table in DropHoodieTableCommand

2022-05-15 Thread GitBox
jinxing64 commented on code in PR #5564: URL: https://github.com/apache/hudi/pull/5564#discussion_r873331963 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/DropHoodieTableCommand.scala: ## @@ -69,13 +67,13 @@ extends HoodieLeafRunnabl

[GitHub] [hudi] jinxing64 commented on a diff in pull request #5564: [HUDI-4087] Support dropping RO and RT table in DropHoodieTableCommand

2022-05-14 Thread GitBox
jinxing64 commented on code in PR #5564: URL: https://github.com/apache/hudi/pull/5564#discussion_r873107339 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/DropHoodieTableCommand.scala: ## @@ -88,42 +86,33 @@ extends HoodieLeafRunnabl

[GitHub] [hudi] jinxing64 commented on a diff in pull request #5564: [HUDI-4087] Support dropping RO and RT table in DropHoodieTableCommand

2022-05-14 Thread GitBox
jinxing64 commented on code in PR #5564: URL: https://github.com/apache/hudi/pull/5564#discussion_r873107298 ## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestDropTable.scala: ## @@ -72,4 +72,154 @@ class TestDropTable extends HoodieSparkSqlTestBas

[GitHub] [hudi] jinxing64 commented on a diff in pull request #5564: [HUDI-4087] Support dropping RO and RT table in DropHoodieTableCommand

2022-05-14 Thread GitBox
jinxing64 commented on code in PR #5564: URL: https://github.com/apache/hudi/pull/5564#discussion_r873107281 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/DropHoodieTableCommand.scala: ## @@ -88,42 +86,33 @@ extends HoodieLeafRunnabl