jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1164679885
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieBootstrapConfig.java:
##
@@ -83,8 +79,8 @@ public class HoodieBootstrapConfig extends HoodieCon
jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1163391536
##
hudi-common/src/test/java/org/apache/hudi/common/config/TestConfigProperty.java:
##
@@ -171,4 +171,28 @@ public void testAdvancedValue() {
assertTrue(FAKE_BOOLEAN_C
jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1163375572
##
hudi-common/src/main/java/org/apache/hudi/common/config/ConfigProperty.java:
##
@@ -139,6 +144,49 @@ public ConfigProperty withDocumentation(String doc) {
return ne
jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1163352137
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##
@@ -168,23 +168,16 @@ public class HoodieWriteConfig extends HoodieConfig
jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1163346107
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieClusteringConfig.java:
##
@@ -732,40 +712,17 @@ public String getValue() {
}
}
+ @En
jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1163302008
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/bootstrap/BootstrapMode.java:
##
@@ -18,18 +18,28 @@
package org.apache.hudi.client.bootstrap;
+
jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1163153414
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##
@@ -194,16 +187,18 @@ public class HoodieWriteConfig extends HoodieConfig
jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1156300665
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##
@@ -2929,12 +2892,12 @@ private void
autoAdjustConfigsForConcurrencyMode(
jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1156299374
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieCleanConfig.java:
##
@@ -64,25 +62,20 @@ public class HoodieCleanConfig extends HoodieConfig {
jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1156298274
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieBootstrapConfig.java:
##
@@ -55,12 +52,10 @@ public class HoodieBootstrapConfig extends HoodieC
jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1106023838
##
hudi-common/src/main/java/org/apache/hudi/keygen/constant/KeyGeneratorType.java:
##
@@ -18,47 +18,41 @@
package org.apache.hudi.keygen.constant;
+import org.apache.
jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1106023367
##
hudi-common/src/main/java/org/apache/hudi/common/util/queue/ExecutorType.java:
##
@@ -18,27 +18,27 @@
package org.apache.hudi.common.util.queue;
+import org.apache.
jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1106022582
##
hudi-common/src/main/java/org/apache/hudi/common/util/queue/DisruptorWaitStrategyType.java:
##
@@ -27,35 +30,50 @@
/**
* Enum for the type of waiting strategy in Disr
jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1106021736
##
hudi-common/src/main/java/org/apache/hudi/common/table/marker/MarkerType.java:
##
@@ -19,10 +19,23 @@
package org.apache.hudi.common.table.marker;
+import org.apach
jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1106016160
##
hudi-common/src/main/java/org/apache/hudi/common/bloom/BloomFilterTypeCode.java:
##
@@ -18,11 +18,21 @@
package org.apache.hudi.common.bloom;
+import org.apache.hud
jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1106015149
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/storage/HoodieStorageLayout.java:
##
@@ -50,7 +53,14 @@ public HoodieStorageLayout(HoodieWriteConfig c
jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1106014556
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/CompactionTriggerStrategy.java:
##
@@ -18,15 +18,31 @@
package org.apache.hudi.table
jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1106012580
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/cluster/ClusteringPlanPartitionFilterMode.java:
##
@@ -18,12 +18,31 @@
package org.apache.hu
jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1106011282
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleaningTriggerStrategy.java:
##
@@ -18,7 +18,14 @@
package org.apache.hudi.table.acti
jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1106009875
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndex.java:
##
@@ -152,11 +155,51 @@ public boolean requiresTagging(WriteOperationType
operatio
jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1106008290
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##
@@ -1912,6 +1871,10 @@ public Option
getLogDataBlockFormat() {
.
jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1106007724
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##
@@ -187,16 +178,18 @@ public class HoodieWriteConfig extends HoodieConfig
jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1106006641
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java:
##
@@ -74,11 +74,10 @@ public class HoodieIndexConfig extends HoodieConfig {
jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1106005114
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieClusteringConfig.java:
##
@@ -692,9 +687,17 @@ public static SpatialCurveCompositionStrategyTyp
jonvex commented on code in PR #7881:
URL: https://github.com/apache/hudi/pull/7881#discussion_r1106001981
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/bootstrap/BootstrapMode.java:
##
@@ -18,18 +18,27 @@
package org.apache.hudi.client.bootstrap;
+
25 matches
Mail list logo
