subject:"\[GitHub\] \[hudi\] kazdy commented on a diff in pull request #8047\: \[HUDI\-5848\]\[SPARK\] No PreCombineField mode \- make COMBINE_BEFORE_UPSERT=false automatically"

[GitHub] [hudi] kazdy commented on a diff in pull request #8047: [HUDI-5848][SPARK] No PreCombineField mode - make COMBINE_BEFORE_UPSERT=false automatically

2023-02-25 Thread via GitHub

kazdy commented on code in PR #8047: URL: https://github.com/apache/hudi/pull/8047#discussion_r1117978967 ## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/TestHoodieSparkSqlWriter.scala: ## @@ -454,6 +454,38 @@ class TestHoodieSparkSqlWriter { assert(df.ex

[GitHub] [hudi] kazdy commented on a diff in pull request #8047: [HUDI-5848][SPARK] No PreCombineField mode - make COMBINE_BEFORE_UPSERT=false automatically

2023-02-25 Thread via GitHub

kazdy commented on code in PR #8047: URL: https://github.com/apache/hudi/pull/8047#discussion_r1117978967 ## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/TestHoodieSparkSqlWriter.scala: ## @@ -454,6 +454,38 @@ class TestHoodieSparkSqlWriter { assert(df.ex