[GitHub] [hudi] leesf commented on a change in pull request #2645: [HUDI-1659] Basic Implementation Of Spark Sql Support

leesf commented on a change in pull request #2645: URL: https://github.com/apache/hudi/pull/2645#discussion_r614124751 ## File path: hudi-common/src/main/java/org/apache/hudi/common/model/DefaultHoodieRecordPayload.java ## @@ -97,4 +86,20 @@ public DefaultHoodieRecordPayload(O

[GitHub] [hudi] leesf commented on a change in pull request #2645: [HUDI-1659] Basic Implementation Of Spark Sql Support

leesf commented on a change in pull request #2645: URL: https://github.com/apache/hudi/pull/2645#discussion_r614125206 ## File path: hudi-common/src/main/java/org/apache/hudi/common/model/DefaultHoodieRecordPayload.java ## @@ -97,4 +86,20 @@ public DefaultHoodieRecordPayload(O

[GitHub] [hudi] leesf commented on a change in pull request #2645: [HUDI-1659] Basic Implementation Of Spark Sql Support

leesf commented on a change in pull request #2645: URL: https://github.com/apache/hudi/pull/2645#discussion_r614125884 ## File path: hudi-common/src/main/java/org/apache/hudi/common/model/HoodiePayloadProps.java ## @@ -40,4 +40,12 @@ */ public static final String PAYLOA

[GitHub] [hudi] leesf commented on a change in pull request #2645: [HUDI-1659] Basic Implementation Of Spark Sql Support

leesf commented on a change in pull request #2645: URL: https://github.com/apache/hudi/pull/2645#discussion_r614133690 ## File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/MergeOnReadSnapshotRelation.scala ## @@ -61,8 +62,17 @@ class MergeOnReadSnapsho

[GitHub] [hudi] leesf commented on a change in pull request #2645: [HUDI-1659] Basic Implementation Of Spark Sql Support

leesf commented on a change in pull request #2645: URL: https://github.com/apache/hudi/pull/2645#discussion_r614135849 ## File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/SparkSqlAdapterSupport.scala ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache

[GitHub] [hudi] leesf commented on a change in pull request #2645: [HUDI-1659] Basic Implementation Of Spark Sql Support

leesf commented on a change in pull request #2645: URL: https://github.com/apache/hudi/pull/2645#discussion_r614141295 ## File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieAnalysis.scala ## @@ -0,0 +1,318 @@ +/* + * Licensed to

[GitHub] [hudi] leesf commented on a change in pull request #2645: [HUDI-1659] Basic Implementation Of Spark Sql Support

leesf commented on a change in pull request #2645: URL: https://github.com/apache/hudi/pull/2645#discussion_r614142192 ## File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/CreateHoodieTableAsSelectCommand.scala ## @@ -0,0 +1,69 @@ +/*

[GitHub] [hudi] leesf commented on a change in pull request #2645: [HUDI-1659] Basic Implementation Of Spark Sql Support

leesf commented on a change in pull request #2645: URL: https://github.com/apache/hudi/pull/2645#discussion_r614142342 ## File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/CreateHoodieTableAsSelectCommand.scala ## @@ -0,0 +1,69 @@ +/*

[GitHub] [hudi] leesf commented on a change in pull request #2645: [HUDI-1659] Basic Implementation Of Spark Sql Support

leesf commented on a change in pull request #2645: URL: https://github.com/apache/hudi/pull/2645#discussion_r614150697 ## File path: hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestCreateTable.scala ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apa

[GitHub] [hudi] leesf commented on a change in pull request #2645: [HUDI-1659] Basic Implementation Of Spark Sql Support

leesf commented on a change in pull request #2645: URL: https://github.com/apache/hudi/pull/2645#discussion_r614152609 ## File path: hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestDelete.scala ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache So

[GitHub] [hudi] leesf commented on a change in pull request #2645: [HUDI-1659] Basic Implementation Of Spark Sql Support

leesf commented on a change in pull request #2645: URL: https://github.com/apache/hudi/pull/2645#discussion_r614153933 ## File path: hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestDelete.scala ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache So

[GitHub] [hudi] leesf commented on a change in pull request #2645: [HUDI-1659] Basic Implementation Of Spark Sql Support

leesf commented on a change in pull request #2645: URL: https://github.com/apache/hudi/pull/2645#discussion_r615328076 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java ## @@ -444,7 +448,9 @@ private void writeToBuffer(Hoodie

[GitHub] [hudi] leesf commented on a change in pull request #2645: [HUDI-1659] Basic Implementation Of Spark Sql Support

leesf commented on a change in pull request #2645: URL: https://github.com/apache/hudi/pull/2645#discussion_r615328489 ## File path: hudi-common/src/main/java/org/apache/hudi/common/model/DefaultHoodieRecordPayload.java ## @@ -97,4 +86,22 @@ public DefaultHoodieRecordPayload(O