[GitHub] [hudi] leesf commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write

leesf commented on a change in pull request #3823: URL: https://github.com/apache/hudi/pull/3823#discussion_r740215442 ## File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala ## @@ -34,9 +35,9 @@ import

[GitHub] [hudi] leesf commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write

leesf commented on a change in pull request #3823: URL: https://github.com/apache/hudi/pull/3823#discussion_r740213590 ## File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieWriterUtils.scala ## @@ -92,10 +92,9 @@ object HoodieWriterUtils { * @

[GitHub] [hudi] leesf commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write

leesf commented on a change in pull request #3823: URL: https://github.com/apache/hudi/pull/3823#discussion_r736670911 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java ## @@ -717,6 +719,16 @@ public PropertyBuilder setKeyGenerator

[GitHub] [hudi] leesf commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write

leesf commented on a change in pull request #3823: URL: https://github.com/apache/hudi/pull/3823#discussion_r736665214 ## File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala ## @@ -74,16 +77,23 @@ object HoodieSparkSqlWriter {

[GitHub] [hudi] leesf commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write

leesf commented on a change in pull request #3823: URL: https://github.com/apache/hudi/pull/3823#discussion_r736664105 ## File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala ## @@ -64,7 +67,7 @@ object HoodieSparkSqlWriter {

[GitHub] [hudi] leesf commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write

leesf commented on a change in pull request #3823: URL: https://github.com/apache/hudi/pull/3823#discussion_r736660076 ## File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/keygen/TestCustomKeyGenerator.java ## @@ -259,7 +268,7 @@ public void testNoRecordKe

[GitHub] [hudi] leesf commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write

leesf commented on a change in pull request #3823: URL: https://github.com/apache/hudi/pull/3823#discussion_r736658212 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/factory/HoodieSparkKeyGeneratorFactory.java ## @@ -51,44 +49,70 @@ private

[GitHub] [hudi] leesf commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write

leesf commented on a change in pull request #3823: URL: https://github.com/apache/hudi/pull/3823#discussion_r736658212 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/factory/HoodieSparkKeyGeneratorFactory.java ## @@ -51,44 +49,70 @@ private

[GitHub] [hudi] leesf commented on a change in pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write

leesf commented on a change in pull request #3823: URL: https://github.com/apache/hudi/pull/3823#discussion_r736655928 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/factory/HoodieSparkKeyGeneratorFactory.java ## @@ -51,44 +49,70 @@ private