[GitHub] [hudi] leesf commented on a change in pull request #4514: [HUDI-3172] Refactor hudi existing modules to make more code reuse in V2 Implementation

2022-01-06 Thread GitBox
leesf commented on a change in pull request #4514: URL: https://github.com/apache/hudi/pull/4514#discussion_r780047010 ## File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DefaultSource.scala ## @@ -177,7 +177,7 @@ class DefaultSource extends Re

[GitHub] [hudi] leesf commented on a change in pull request #4514: [HUDI-3172] Refactor hudi existing modules to make more code reuse in V2 Implementation

2022-01-06 Thread GitBox
leesf commented on a change in pull request #4514: URL: https://github.com/apache/hudi/pull/4514#discussion_r780047010 ## File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DefaultSource.scala ## @@ -177,7 +177,7 @@ class DefaultSource extends Re

[GitHub] [hudi] leesf commented on a change in pull request #4514: [HUDI-3172] Refactor hudi existing modules to make more code reuse in V2 Implementation

2022-01-06 Thread GitBox
leesf commented on a change in pull request #4514: URL: https://github.com/apache/hudi/pull/4514#discussion_r779377180 ## File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/HoodieSqlCommonUtils.scala ## @@ -0,0 +1,316 @@ +/* + * License

[GitHub] [hudi] leesf commented on a change in pull request #4514: [HUDI-3172] Refactor hudi existing modules to make more code reuse in V2 Implementation

2022-01-06 Thread GitBox
leesf commented on a change in pull request #4514: URL: https://github.com/apache/hudi/pull/4514#discussion_r779369728 ## File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/HoodieSqlCommonUtils.scala ## @@ -0,0 +1,316 @@ +/* + * License

[GitHub] [hudi] leesf commented on a change in pull request #4514: [HUDI-3172] Refactor hudi existing modules to make more code reuse in V2 Implementation

2022-01-06 Thread GitBox
leesf commented on a change in pull request #4514: URL: https://github.com/apache/hudi/pull/4514#discussion_r779368601 ## File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/HoodieSqlCommonUtils.scala ## @@ -0,0 +1,316 @@ +/* + * License

[GitHub] [hudi] leesf commented on a change in pull request #4514: [HUDI-3172] Refactor hudi existing modules to make more code reuse in V2 Implementation

2022-01-05 Thread GitBox
leesf commented on a change in pull request #4514: URL: https://github.com/apache/hudi/pull/4514#discussion_r779339698 ## File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/HoodieSqlCommonUtils.scala ## @@ -0,0 +1,316 @@ +/* + * License

[GitHub] [hudi] leesf commented on a change in pull request #4514: [HUDI-3172] Refactor hudi existing modules to make more code reuse in V2 Implementation

2022-01-05 Thread GitBox
leesf commented on a change in pull request #4514: URL: https://github.com/apache/hudi/pull/4514#discussion_r779339698 ## File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/HoodieSqlCommonUtils.scala ## @@ -0,0 +1,316 @@ +/* + * License

[GitHub] [hudi] leesf commented on a change in pull request #4514: [HUDI-3172] Refactor hudi existing modules to make more code reuse in V2 Implementation

2022-01-05 Thread GitBox
leesf commented on a change in pull request #4514: URL: https://github.com/apache/hudi/pull/4514#discussion_r779325386 ## File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DefaultSource.scala ## @@ -177,7 +177,7 @@ class DefaultSource extends Re

[GitHub] [hudi] leesf commented on a change in pull request #4514: [HUDI-3172] Refactor hudi existing modules to make more code reuse in V2 Implementation

2022-01-05 Thread GitBox
leesf commented on a change in pull request #4514: URL: https://github.com/apache/hudi/pull/4514#discussion_r779318890 ## File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/ValidateDuplicateKeyPayload.scala ## @@ -0,0 +1,45 @@ +