[GitHub] [hudi] leesf commented on pull request #4514: [HUDI-3172] Refactor hudi existing modules to make more code reuse in V2 Implementation

2022-01-12 Thread GitBox
leesf commented on pull request #4514: URL: https://github.com/apache/hudi/pull/4514#issuecomment-1011874021 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [hudi] leesf commented on pull request #4514: [HUDI-3172] Refactor hudi existing modules to make more code reuse in V2 Implementation

2022-01-12 Thread GitBox
leesf commented on pull request #4514: URL: https://github.com/apache/hudi/pull/4514#issuecomment-1011827421 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [hudi] leesf commented on pull request #4514: [HUDI-3172] Refactor hudi existing modules to make more code reuse in V2 Implementation

2022-01-12 Thread GitBox
leesf commented on pull request #4514: URL: https://github.com/apache/hudi/pull/4514#issuecomment-1011774260 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [hudi] leesf commented on pull request #4514: [HUDI-3172] Refactor hudi existing modules to make more code reuse in V2 Implementation

2022-01-12 Thread GitBox
leesf commented on pull request #4514: URL: https://github.com/apache/hudi/pull/4514#issuecomment-1011711249 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [hudi] leesf commented on pull request #4514: [HUDI-3172] Refactor hudi existing modules to make more code reuse in V2 Implementation

2022-01-12 Thread GitBox
leesf commented on pull request #4514: URL: https://github.com/apache/hudi/pull/4514#issuecomment-1011628054 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [hudi] leesf commented on pull request #4514: [HUDI-3172] Refactor hudi existing modules to make more code reuse in V2 Implementation

2022-01-12 Thread GitBox
leesf commented on pull request #4514: URL: https://github.com/apache/hudi/pull/4514#issuecomment-1010930395 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [hudi] leesf commented on pull request #4514: [HUDI-3172] Refactor hudi existing modules to make more code reuse in V2 Implementation

2022-01-10 Thread GitBox
leesf commented on pull request #4514: URL: https://github.com/apache/hudi/pull/4514#issuecomment-1009684128 > @leesf yes we won't have conflicting patches to pick from master. we can land this one now. @xushiyan CI passed, so can we merge? -- This is an automated message from the

[GitHub] [hudi] leesf commented on pull request #4514: [HUDI-3172] Refactor hudi existing modules to make more code reuse in V2 Implementation

2022-01-10 Thread GitBox
leesf commented on pull request #4514: URL: https://github.com/apache/hudi/pull/4514#issuecomment-1009520956 > yeah, would really appreciate if we can wait until Jan 9 to land this patch. thanks! @nsivabalan @xushiyan time to land this patch? -- This is an automated message from t

[GitHub] [hudi] leesf commented on pull request #4514: [HUDI-3172] Refactor hudi existing modules to make more code reuse in V2 Implementation

2022-01-08 Thread GitBox
leesf commented on pull request #4514: URL: https://github.com/apache/hudi/pull/4514#issuecomment-1007441054 > @leesf few questions. > > 1. What do the hudi-spark2-extensions/hudi-spark3-extensions do? What code would these have in the future? > 2. Users may have spark jobs that d

[GitHub] [hudi] leesf commented on pull request #4514: [HUDI-3172] Refactor hudi existing modules to make more code reuse in V2 Implementation

2022-01-07 Thread GitBox
leesf commented on pull request #4514: URL: https://github.com/apache/hudi/pull/4514#issuecomment-1007441054 > @leesf few questions. > > 1. What do the hudi-spark2-extensions/hudi-spark3-extensions do? What code would these have in the future? > 2. Users may have spark jobs that d

[GitHub] [hudi] leesf commented on pull request #4514: [HUDI-3172] Refactor hudi existing modules to make more code reuse in V2 Implementation

2022-01-06 Thread GitBox
leesf commented on pull request #4514: URL: https://github.com/apache/hudi/pull/4514#issuecomment-1006364350 > Let me make another pass at all the pom changes. That seems to be main thing here. In the meantime, could you clarify these comments? > > Also have you tested these changes