[GitHub] [hudi] lokeshj1703 commented on a diff in pull request #8631: [HUDI-6170] Use correct zone id while calculating earliestTimeToRetain

2023-05-09 Thread via GitHub
lokeshj1703 commented on code in PR #8631: URL: https://github.com/apache/hudi/pull/8631#discussion_r1188380042 ## hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstantTimeGenerator.java: ## @@ -135,7 +133,7 @@ private static TemporalAccessor convertDate

[GitHub] [hudi] lokeshj1703 commented on a diff in pull request #8631: [HUDI-6170] Use correct zone id while calculating earliestTimeToRetain

2023-05-09 Thread via GitHub
lokeshj1703 commented on code in PR #8631: URL: https://github.com/apache/hudi/pull/8631#discussion_r1188380042 ## hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstantTimeGenerator.java: ## @@ -135,7 +133,7 @@ private static TemporalAccessor convertDate

[GitHub] [hudi] lokeshj1703 commented on a diff in pull request #8631: [HUDI-6170] Use correct zone id while calculating earliestTimeToRetain

2023-05-09 Thread via GitHub
lokeshj1703 commented on code in PR #8631: URL: https://github.com/apache/hudi/pull/8631#discussion_r1188376891 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanPlanner.java: ## @@ -510,7 +510,7 @@ public Option getEarliestCommitToRetain()

[GitHub] [hudi] lokeshj1703 commented on a diff in pull request #8631: [HUDI-6170] Use correct zone id while calculating earliestTimeToRetain

2023-05-09 Thread via GitHub
lokeshj1703 commented on code in PR #8631: URL: https://github.com/apache/hudi/pull/8631#discussion_r1188232721 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanPlanner.java: ## @@ -510,7 +510,7 @@ public Option getEarliestCommitToRetain()

[GitHub] [hudi] lokeshj1703 commented on a diff in pull request #8631: [HUDI-6170] Use correct zone id while calculating earliestTimeToRetain

2023-05-08 Thread via GitHub
lokeshj1703 commented on code in PR #8631: URL: https://github.com/apache/hudi/pull/8631#discussion_r1187365382 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanPlanner.java: ## @@ -510,7 +510,7 @@ public Option getEarliestCommitToRetain()

[GitHub] [hudi] lokeshj1703 commented on a diff in pull request #8631: [HUDI-6170] Use correct zone id while calculating earliestTimeToRetain

2023-05-04 Thread via GitHub
lokeshj1703 commented on code in PR #8631: URL: https://github.com/apache/hudi/pull/8631#discussion_r1185732010 ## hudi-common/src/main/java/org/apache/hudi/common/model/HoodieTimelineTimeZone.java: ## @@ -18,20 +18,29 @@ package org.apache.hudi.common.model; +import java.t