[GitHub] [hudi] n3nash commented on a change in pull request #2400: Some fixes and enhancements to test suite framework

2021-01-31 Thread GitBox
n3nash commented on a change in pull request #2400: URL: https://github.com/apache/hudi/pull/2400#discussion_r567569928 ## File path: hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/dag/nodes/ValidateAsyncOperations.java ## @@ -0,0 +1,119 @@ +/* + * Licensed to t

[GitHub] [hudi] n3nash commented on a change in pull request #2400: Some fixes and enhancements to test suite framework

2021-01-31 Thread GitBox
n3nash commented on a change in pull request #2400: URL: https://github.com/apache/hudi/pull/2400#discussion_r567569713 ## File path: hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/dag/nodes/ValidateAsyncOperations.java ## @@ -0,0 +1,119 @@ +/* + * Licensed to t

[GitHub] [hudi] n3nash commented on a change in pull request #2400: Some fixes and enhancements to test suite framework

2021-01-31 Thread GitBox
n3nash commented on a change in pull request #2400: URL: https://github.com/apache/hudi/pull/2400#discussion_r567569596 ## File path: hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/dag/nodes/ValidateAsyncOperations.java ## @@ -0,0 +1,119 @@ +/* + * Licensed to t

[GitHub] [hudi] n3nash commented on a change in pull request #2400: Some fixes and enhancements to test suite framework

2021-01-31 Thread GitBox
n3nash commented on a change in pull request #2400: URL: https://github.com/apache/hudi/pull/2400#discussion_r567569480 ## File path: hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/dag/nodes/ValidateAsyncOperations.java ## @@ -0,0 +1,119 @@ +/* + * Licensed to t

[GitHub] [hudi] n3nash commented on a change in pull request #2400: Some fixes and enhancements to test suite framework

2021-01-31 Thread GitBox
n3nash commented on a change in pull request #2400: URL: https://github.com/apache/hudi/pull/2400#discussion_r567569285 ## File path: hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/dag/nodes/CompactNode.java ## @@ -40,10 +40,11 @@ public CompactNode(Config confi

[GitHub] [hudi] n3nash commented on a change in pull request #2400: Some fixes and enhancements to test suite framework

2021-01-31 Thread GitBox
n3nash commented on a change in pull request #2400: URL: https://github.com/apache/hudi/pull/2400#discussion_r567569175 ## File path: hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/dag/nodes/ClusteringNode.java ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache

[GitHub] [hudi] n3nash commented on a change in pull request #2400: Some fixes and enhancements to test suite framework

2021-01-31 Thread GitBox
n3nash commented on a change in pull request #2400: URL: https://github.com/apache/hudi/pull/2400#discussion_r567568943 ## File path: hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/dag/nodes/CleanNode.java ## @@ -32,7 +32,7 @@ public CleanNode(Config config) {

[GitHub] [hudi] n3nash commented on a change in pull request #2400: Some fixes and enhancements to test suite framework

2021-01-31 Thread GitBox
n3nash commented on a change in pull request #2400: URL: https://github.com/apache/hudi/pull/2400#discussion_r567568804 ## File path: hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/configuration/DeltaConfig.java ## @@ -88,6 +88,10 @@ public Configuration getConf

[GitHub] [hudi] n3nash commented on a change in pull request #2400: Some fixes and enhancements to test suite framework

2021-01-31 Thread GitBox
n3nash commented on a change in pull request #2400: URL: https://github.com/apache/hudi/pull/2400#discussion_r567568684 ## File path: hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/HoodieTestSuiteWriter.java ## @@ -178,6 +189,19 @@ private boolean allowWriteClie

[GitHub] [hudi] n3nash commented on a change in pull request #2400: Some fixes and enhancements to test suite framework

2021-01-31 Thread GitBox
n3nash commented on a change in pull request #2400: URL: https://github.com/apache/hudi/pull/2400#discussion_r567568366 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -707,7 +707,7 @@ public abstract void

[GitHub] [hudi] n3nash commented on a change in pull request #2400: Some fixes and enhancements to test suite framework

2021-01-31 Thread GitBox
n3nash commented on a change in pull request #2400: URL: https://github.com/apache/hudi/pull/2400#discussion_r567568178 ## File path: docker/demo/config/test-suite/cow-clustering-example.yaml ## @@ -0,0 +1,76 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# o

[GitHub] [hudi] n3nash commented on a change in pull request #2400: Some fixes and enhancements to test suite framework

2021-01-31 Thread GitBox
n3nash commented on a change in pull request #2400: URL: https://github.com/apache/hudi/pull/2400#discussion_r567567678 ## File path: docker/demo/config/test-suite/complex-dag-mor.yaml ## @@ -13,107 +13,72 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or im

[GitHub] [hudi] n3nash commented on a change in pull request #2400: Some fixes and enhancements to test suite framework

2021-01-31 Thread GitBox
n3nash commented on a change in pull request #2400: URL: https://github.com/apache/hudi/pull/2400#discussion_r567567637 ## File path: docker/demo/config/test-suite/complex-dag-mor.yaml ## @@ -13,107 +13,72 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or im

[GitHub] [hudi] n3nash commented on a change in pull request #2400: Some fixes and enhancements to test suite framework

2021-01-09 Thread GitBox
n3nash commented on a change in pull request #2400: URL: https://github.com/apache/hudi/pull/2400#discussion_r554496508 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java ## @@ -307,7 +307,10 @@ public void refreshTimeline() throw

[GitHub] [hudi] n3nash commented on a change in pull request #2400: Some fixes and enhancements to test suite framework

2021-01-09 Thread GitBox
n3nash commented on a change in pull request #2400: URL: https://github.com/apache/hudi/pull/2400#discussion_r554496508 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java ## @@ -307,7 +307,10 @@ public void refreshTimeline() throw

[GitHub] [hudi] n3nash commented on a change in pull request #2400: Some fixes and enhancements to test suite framework

2021-01-09 Thread GitBox
n3nash commented on a change in pull request #2400: URL: https://github.com/apache/hudi/pull/2400#discussion_r554496508 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java ## @@ -307,7 +307,10 @@ public void refreshTimeline() throw