subject:"\[GitHub\] \[hudi\] n3nash commented on pull request #2071\: \[HUDI\-1143\] Change timestamp field in HoodieTestDataGenerator from double to long"

[GitHub] [hudi] n3nash commented on pull request #2071: [HUDI-1143] Change timestamp field in HoodieTestDataGenerator from double to long

2020-09-15 Thread GitBox

n3nash commented on pull request #2071: URL: https://github.com/apache/hudi/pull/2071#issuecomment-693154745 @shenh062326 thanks for explaining. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hudi] n3nash commented on pull request #2071: [HUDI-1143] Change timestamp field in HoodieTestDataGenerator from double to long

2020-09-12 Thread GitBox

n3nash commented on pull request #2071: URL: https://github.com/apache/hudi/pull/2071#issuecomment-691200964 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hudi] n3nash commented on pull request #2071: [HUDI-1143] Change timestamp field in HoodieTestDataGenerator from double to long

2020-09-12 Thread GitBox

n3nash commented on pull request #2071: URL: https://github.com/apache/hudi/pull/2071#issuecomment-691200964 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hudi] n3nash commented on pull request #2071: [HUDI-1143] Change timestamp field in HoodieTestDataGenerator from double to long

2020-09-11 Thread GitBox

n3nash commented on pull request #2071: URL: https://github.com/apache/hudi/pull/2071#issuecomment-691200964 @shenh062326 The PR looks fine to me, high level, what is the reason for this change ? Is it just to correct timestamp types ?