[GitHub] [hudi] nsivabalan commented on a change in pull request #2421: [HUDI-1502] MOR rollback and restore support for metadata sync

2021-01-10 Thread GitBox
nsivabalan commented on a change in pull request #2421: URL: https://github.com/apache/hudi/pull/2421#discussion_r554629191 ## File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/rollback/TestMarkerBasedRollbackStrategy.java ## @@ -40,88 +48,103

[GitHub] [hudi] nsivabalan commented on a change in pull request #2421: [HUDI-1502] MOR rollback and restore support for metadata sync

2021-01-10 Thread GitBox
nsivabalan commented on a change in pull request #2421: URL: https://github.com/apache/hudi/pull/2421#discussion_r554629191 ## File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/rollback/TestMarkerBasedRollbackStrategy.java ## @@ -40,88 +48,103

[GitHub] [hudi] nsivabalan commented on a change in pull request #2421: [HUDI-1502] MOR rollback and restore support for metadata sync

2021-01-10 Thread GitBox
nsivabalan commented on a change in pull request #2421: URL: https://github.com/apache/hudi/pull/2421#discussion_r554629618 ## File path: hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java ## @@ -262,18 +264,31 @@ private static void processRollba

[GitHub] [hudi] nsivabalan commented on a change in pull request #2421: [HUDI-1502] MOR rollback and restore support for metadata sync

2021-01-10 Thread GitBox
nsivabalan commented on a change in pull request #2421: URL: https://github.com/apache/hudi/pull/2421#discussion_r554629191 ## File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/rollback/TestMarkerBasedRollbackStrategy.java ## @@ -40,88 +48,103

[GitHub] [hudi] nsivabalan commented on a change in pull request #2421: [HUDI-1502] MOR rollback and restore support for metadata sync

2021-01-09 Thread GitBox
nsivabalan commented on a change in pull request #2421: URL: https://github.com/apache/hudi/pull/2421#discussion_r554485833 ## File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/rollback/TestMarkerBasedRollbackStrategy.java ## @@ -102,8 +112,10

[GitHub] [hudi] nsivabalan commented on a change in pull request #2421: [HUDI-1502] MOR rollback and restore support for metadata sync

2021-01-09 Thread GitBox
nsivabalan commented on a change in pull request #2421: URL: https://github.com/apache/hudi/pull/2421#discussion_r554470295 ## File path: hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java ## @@ -225,25 +216,23 @@ /** * Extracts information

[GitHub] [hudi] nsivabalan commented on a change in pull request #2421: [HUDI-1502] MOR rollback and restore support for metadata sync

2021-01-09 Thread GitBox
nsivabalan commented on a change in pull request #2421: URL: https://github.com/apache/hudi/pull/2421#discussion_r554469890 ## File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/metadata/TestHoodieBackedMetadata.java ## @@ -794,7 +788,19 @@ private void val

[GitHub] [hudi] nsivabalan commented on a change in pull request #2421: [HUDI-1502] MOR rollback and restore support for metadata sync

2021-01-09 Thread GitBox
nsivabalan commented on a change in pull request #2421: URL: https://github.com/apache/hudi/pull/2421#discussion_r554469816 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/rollback/ListingBasedRollbackHelper.java ## @@ -116,14 +116,31 @@

[GitHub] [hudi] nsivabalan commented on a change in pull request #2421: [HUDI-1502] MOR rollback and restore support for metadata sync

2021-01-09 Thread GitBox
nsivabalan commented on a change in pull request #2421: URL: https://github.com/apache/hudi/pull/2421#discussion_r554464134 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java ## @@ -164,6 +164,7 @@ private void init(HoodieReco