[GitHub] [hudi] nsivabalan commented on a diff in pull request #5030: [HUDI-3617] MOR compact improve

2022-10-19 Thread GitBox
nsivabalan commented on code in PR #5030: URL: https://github.com/apache/hudi/pull/5030#discussion_r1000139459 ## hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieMergedLogRecordScanner.java: ## @@ -123,25 +133,24 @@ public long getNumMergedRecordsInLog() {

[GitHub] [hudi] nsivabalan commented on a diff in pull request #5030: [HUDI-3617] MOR compact improve

2022-09-07 Thread GitBox
nsivabalan commented on code in PR #5030: URL: https://github.com/apache/hudi/pull/5030#discussion_r965448515 ## hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieMergedLogRecordScanner.java: ## @@ -123,25 +133,24 @@ public long getNumMergedRecordsInLog() {

[GitHub] [hudi] nsivabalan commented on a diff in pull request #5030: [HUDI-3617] MOR compact improve

2022-09-07 Thread GitBox
nsivabalan commented on code in PR #5030: URL: https://github.com/apache/hudi/pull/5030#discussion_r965446760 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/HoodieCompactor.java: ## @@ -280,8 +281,11 @@ HoodieCompactionPlan