[GitHub] [hudi] nsivabalan commented on a diff in pull request #7605: [HUDI-5349] Clean up partially failed restore

2023-01-10 Thread GitBox
nsivabalan commented on code in PR #7605: URL: https://github.com/apache/hudi/pull/7605#discussion_r1066311330 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java: ## @@ -857,11 +860,24 @@ public HoodieRestoreMetadata restoreToInstan

[GitHub] [hudi] nsivabalan commented on a diff in pull request #7605: [HUDI-5349] Clean up partially failed restore

2023-01-06 Thread GitBox
nsivabalan commented on code in PR #7605: URL: https://github.com/apache/hudi/pull/7605#discussion_r1063907200 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java: ## @@ -836,17 +838,19 @@ public boolean rollback(final String commitI

[GitHub] [hudi] nsivabalan commented on a diff in pull request #7605: [HUDI-5349] Clean up partially failed restore

2023-01-06 Thread GitBox
nsivabalan commented on code in PR #7605: URL: https://github.com/apache/hudi/pull/7605#discussion_r1063640166 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/restore/RestoreUtils.java: ## @@ -43,4 +46,24 @@ public static HoodieRestorePlan getRestor

[GitHub] [hudi] nsivabalan commented on a diff in pull request #7605: [HUDI-5349] Clean up partially failed restore

2023-01-06 Thread GitBox
nsivabalan commented on code in PR #7605: URL: https://github.com/apache/hudi/pull/7605#discussion_r1063633199 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/TestClientRollback.java: ## @@ -740,4 +741,117 @@ public void testFallbackToListingBasedRollbackF

[GitHub] [hudi] nsivabalan commented on a diff in pull request #7605: [HUDI-5349] Clean up partially failed restore

2023-01-04 Thread GitBox
nsivabalan commented on code in PR #7605: URL: https://github.com/apache/hudi/pull/7605#discussion_r1061889375 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/restore/RestoreUtils.java: ## @@ -43,4 +45,21 @@ public static HoodieRestorePlan getRestor