[GitHub] [hudi] nsivabalan commented on a diff in pull request #8557: [HUDI-5895] Remove bootstrap key generator configs

2023-05-06 Thread via GitHub
nsivabalan commented on code in PR #8557: URL: https://github.com/apache/hudi/pull/8557#discussion_r1186777965 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala: ## @@ -411,6 +411,11 @@ object DataSourceWriteOptions { .markAdv

[GitHub] [hudi] nsivabalan commented on a diff in pull request #8557: [HUDI-5895] Remove bootstrap key generator configs

2023-05-06 Thread via GitHub
nsivabalan commented on code in PR #8557: URL: https://github.com/apache/hudi/pull/8557#discussion_r1186754142 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala: ## @@ -411,6 +411,11 @@ object DataSourceWriteOptions { .markAdv

[GitHub] [hudi] nsivabalan commented on a diff in pull request #8557: [HUDI-5895] Remove bootstrap key generator configs

2023-04-25 Thread via GitHub
nsivabalan commented on code in PR #8557: URL: https://github.com/apache/hudi/pull/8557#discussion_r1176094157 ## hudi-examples/hudi-examples-spark/src/main/java/org/apache/hudi/examples/spark/HoodieSparkBootstrapExample.java: ## @@ -64,7 +64,6 @@ public static void main(String[