[GitHub] [hudi] nsivabalan commented on a diff in pull request #9311: [HUDI-6607] Fixing RLI schema to support different fileID formats

2023-07-31 Thread via GitHub
nsivabalan commented on code in PR #9311: URL: https://github.com/apache/hudi/pull/9311#discussion_r1280016059 ## hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataPayload.java: ## Review Comment: Entire RLI is a new addition. we did not have one with 0.13.0.

[GitHub] [hudi] nsivabalan commented on a diff in pull request #9311: [HUDI-6607] Fixing RLI schema to support different fileID formats

2023-07-31 Thread via GitHub
nsivabalan commented on code in PR #9311: URL: https://github.com/apache/hudi/pull/9311#discussion_r1280015823 ## hudi-common/src/main/avro/HoodieMetadata.avsc: ## Review Comment: we need more jamming on rowId. thats why -- This is an automated message from the Apache G

[GitHub] [hudi] nsivabalan commented on a diff in pull request #9311: [HUDI-6607] Fixing RLI schema to support different fileID formats

2023-07-31 Thread via GitHub
nsivabalan commented on code in PR #9311: URL: https://github.com/apache/hudi/pull/9311#discussion_r1280015743 ## hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataPayload.java: ## @@ -166,11 +166,15 @@ public class HoodieMetadataPayload implements HoodieRecordPa

[GitHub] [hudi] nsivabalan commented on a diff in pull request #9311: [HUDI-6607] Fixing RLI schema to support different fileID formats

2023-07-31 Thread via GitHub
nsivabalan commented on code in PR #9311: URL: https://github.com/apache/hudi/pull/9311#discussion_r1280015250 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java: ## @@ -727,6 +728,11 @@ public class HoodieWriteConfig extends HoodieConf