[GitHub] [hudi] nsivabalan commented on pull request #1978: [HUDI-1184] Fix the support of hbase index partition path change

2020-09-14 Thread GitBox
nsivabalan commented on pull request #1978: URL: https://github.com/apache/hudi/pull/1978#issuecomment-692196027 @n3nash : not sure if you had any issues w/ tests. my feeback is addressed and patch is good from my end. Please land it if you are fine with the patch.

[GitHub] [hudi] nsivabalan commented on pull request #1978: [HUDI-1184] Fix the support of hbase index partition path change

2020-09-12 Thread GitBox
nsivabalan commented on pull request #1978: URL: https://github.com/apache/hudi/pull/1978#issuecomment-691579116 > @nsivabalan are you good with the test changes like @hj2016 is asking? please clarify I did review the commit that addressed my concern and only then approved the PR.

[GitHub] [hudi] nsivabalan commented on pull request #1978: [HUDI-1184] Fix the support of hbase index partition path change

2020-09-08 Thread GitBox
nsivabalan commented on pull request #1978: URL: https://github.com/apache/hudi/pull/1978#issuecomment-689043555 @hj2016 : can you fix the build failure. This is an automated message from the Apache Git Service. To respond