[GitHub] [hudi] nsivabalan commented on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-06-22 Thread GitBox
nsivabalan commented on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-865486663 @n3nash : Can you please respond to the author. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hudi] nsivabalan commented on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-06-21 Thread GitBox
nsivabalan commented on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-865486663 @n3nash : Can you please respond to the author. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hudi] nsivabalan commented on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-06-05 Thread GitBox
nsivabalan commented on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-855236580 @vaibhav-sinha : I recreated this PR cleanly [here](https://github.com/apache/hudi/pull/3039). Have not made fixes to TestCopyOnWrite yet. will wait for flink experts to chime

[GitHub] [hudi] nsivabalan commented on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-06-05 Thread GitBox
nsivabalan commented on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-855233374 @vaibhav-sinha : in the mean time, can you address nishith's feedback on test naming. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hudi] nsivabalan commented on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-05-31 Thread GitBox
nsivabalan commented on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-851480106 @vaibhav-sinha : Not sure how you rebased with master, but I see your commits are interleaved with commits in master. Also, I tried running TestWriteCopyOnWrite tests in apache

[GitHub] [hudi] nsivabalan commented on pull request #2923: [HUDI-1864] Added support for Date, Timestamp, LocalDate and LocalDateTime in TimestampBasedAvroKeyGenerator

2021-05-25 Thread GitBox
nsivabalan commented on pull request #2923: URL: https://github.com/apache/hudi/pull/2923#issuecomment-847933890 Can you check CI failure please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to