[GitHub] [hudi] nsivabalan commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain

nsivabalan commented on PR #5406: URL: https://github.com/apache/hudi/pull/5406#issuecomment-1245443080 I do not want to touch something that existed for 3+ years w/o understanding the repurcussions. will probably wait to hear from vinoth or prasanna/balaji. we can leave the patch open

[GitHub] [hudi] nsivabalan commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain

nsivabalan commented on PR #5406: URL: https://github.com/apache/hudi/pull/5406#issuecomment-1240120146 hey @danny0405 : may be there is some rational behind the original intent. Its just deducting 1 commit from what user wants right. as of now, I don't feel this is giving us much or

[GitHub] [hudi] nsivabalan commented on pull request #5406: [HUDI-3954] Don't keep the last commit before the earliest commit to retain

nsivabalan commented on PR #5406: URL: https://github.com/apache/hudi/pull/5406#issuecomment-1121285353 @vinothchandar @bvaradar : do you folks have any context around why we retain 1 extra commit compared to the configured number for num commits to retain with cleaning? -- This is an