nsivabalan commented on PR #5478:
URL: https://github.com/apache/hudi/pull/5478#issuecomment-1245449558
thanks for the patch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
nsivabalan commented on PR #5478:
URL: https://github.com/apache/hudi/pull/5478#issuecomment-1240126607
also, a good practice to follow. whenever you are addressing feedback, try
to add it as new commits. Easier for reviewer to re-review just the new
changes. if not, I have to review
nsivabalan commented on PR #5478:
URL: https://github.com/apache/hudi/pull/5478#issuecomment-1236276782
@dongkelun : sorry, I dropped the ball on this. can you rebase w/ latest
master. I can review it and we can get it in for 0.12.1.
--
This is an automated message from the Apache
nsivabalan commented on PR #5478:
URL: https://github.com/apache/hudi/pull/5478#issuecomment-1126696763
good find on the bug.
if my understanding is right, lastCompletedCommitTimestamp actually refers
to last CompletedCommit w/o any holes. i.e. before the last completed commit,
there
