[GitHub] [hudi] nsivabalan commented on pull request #9123: [HUDI-6478] Simplifying INSERT_INTO configs for spark-sql

2023-07-12 Thread via GitHub
nsivabalan commented on PR #9123: URL: https://github.com/apache/hudi/pull/9123#issuecomment-1633199465 hey @codope : not sure I understand your question here. `I think this config is also used for datasource inserts. So, now the behavior of datasource and sql will differ for the insert

[GitHub] [hudi] nsivabalan commented on pull request #9123: [HUDI-6478] Simplifying INSERT_INTO configs for spark-sql

2023-07-12 Thread via GitHub
nsivabalan commented on PR #9123: URL: https://github.com/apache/hudi/pull/9123#issuecomment-1633096348 hey @zhuanshenbsj1 I know we are changing the behavior. But we looked at few other systems in similar space and everywhere INSERT_INTO can result in duplicates. And we are taking a hit

[GitHub] [hudi] nsivabalan commented on pull request #9123: [HUDI-6478] Simplifying INSERT_INTO configs for spark-sql

2023-07-09 Thread via GitHub
nsivabalan commented on PR #9123: URL: https://github.com/apache/hudi/pull/9123#issuecomment-1627844217 hey @danny0405 @codope : Updated the patch. rebased w/ latest master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub