[GitHub] [hudi] pengzhiwei2018 commented on a change in pull request #2596: [HUDI-1636] Support Builder Pattern To Build Table Properties For Hoo…

2021-02-26 Thread GitBox
pengzhiwei2018 commented on a change in pull request #2596: URL: https://github.com/apache/hudi/pull/2596#discussion_r583470709 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java ## @@ -258,4 +260,142 @@ public String getArchivelogFolde

[GitHub] [hudi] pengzhiwei2018 commented on a change in pull request #2596: [HUDI-1636] Support Builder Pattern To Build Table Properties For Hoo…

2021-02-26 Thread GitBox
pengzhiwei2018 commented on a change in pull request #2596: URL: https://github.com/apache/hudi/pull/2596#discussion_r583470709 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java ## @@ -258,4 +260,142 @@ public String getArchivelogFolde

[GitHub] [hudi] pengzhiwei2018 commented on a change in pull request #2596: [HUDI-1636] Support Builder Pattern To Build Table Properties For Hoo…

2021-02-26 Thread GitBox
pengzhiwei2018 commented on a change in pull request #2596: URL: https://github.com/apache/hudi/pull/2596#discussion_r583471108 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java ## @@ -258,4 +260,142 @@ public String getArchivelogFolde

[GitHub] [hudi] pengzhiwei2018 commented on a change in pull request #2596: [HUDI-1636] Support Builder Pattern To Build Table Properties For Hoo…

2021-02-26 Thread GitBox
pengzhiwei2018 commented on a change in pull request #2596: URL: https://github.com/apache/hudi/pull/2596#discussion_r583470709 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java ## @@ -258,4 +260,142 @@ public String getArchivelogFolde

[GitHub] [hudi] pengzhiwei2018 commented on a change in pull request #2596: [HUDI-1636] Support Builder Pattern To Build Table Properties For Hoo…

2021-02-26 Thread GitBox
pengzhiwei2018 commented on a change in pull request #2596: URL: https://github.com/apache/hudi/pull/2596#discussion_r583470709 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java ## @@ -258,4 +260,142 @@ public String getArchivelogFolde

[GitHub] [hudi] pengzhiwei2018 commented on a change in pull request #2596: [HUDI-1636] Support Builder Pattern To Build Table Properties For Hoo…

2021-02-25 Thread GitBox
pengzhiwei2018 commented on a change in pull request #2596: URL: https://github.com/apache/hudi/pull/2596#discussion_r583385132 ## File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/TableCommand.java ## @@ -106,10 +106,13 @@ public String createTable( throw n

[GitHub] [hudi] pengzhiwei2018 commented on a change in pull request #2596: [HUDI-1636] Support Builder Pattern To Build Table Properties For Hoo…

2021-02-25 Thread GitBox
pengzhiwei2018 commented on a change in pull request #2596: URL: https://github.com/apache/hudi/pull/2596#discussion_r583334728 ## File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/TableCommand.java ## @@ -106,10 +106,13 @@ public String createTable( throw n