[GitHub] [hudi] prashantwason commented on a change in pull request #2701: [HUDI 1623] New Hoodie Instant on disk format with end time and milliseconds granularity

2021-07-02 Thread GitBox
prashantwason commented on a change in pull request #2701: URL: https://github.com/apache/hudi/pull/2701#discussion_r663198643 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstantFormat.java ## @@ -0,0 +1,429 @@ +/* + * Licensed to the

[GitHub] [hudi] prashantwason commented on a change in pull request #2701: [HUDI 1623] New Hoodie Instant on disk format with end time and milliseconds granularity

2021-07-02 Thread GitBox
prashantwason commented on a change in pull request #2701: URL: https://github.com/apache/hudi/pull/2701#discussion_r663196935 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstant.java ## @@ -38,24 +39,24 @@ * A COMPACTION action

[GitHub] [hudi] prashantwason commented on a change in pull request #2701: [HUDI 1623] New Hoodie Instant on disk format with end time and milliseconds granularity

2021-07-02 Thread GitBox
prashantwason commented on a change in pull request #2701: URL: https://github.com/apache/hudi/pull/2701#discussion_r663195101 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java ## @@ -581,14 +582,14 @@ public String

[GitHub] [hudi] prashantwason commented on a change in pull request #2701: [HUDI 1623] New Hoodie Instant on disk format with end time and milliseconds granularity

2021-07-02 Thread GitBox
prashantwason commented on a change in pull request #2701: URL: https://github.com/apache/hudi/pull/2701#discussion_r663193869 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/upgrade/TwoToOneDowngradeHandler.java ## @@ -0,0 +1,66 @@ +/* + *

[GitHub] [hudi] prashantwason commented on a change in pull request #2701: [HUDI 1623] New Hoodie Instant on disk format with end time and milliseconds granularity

2021-07-02 Thread GitBox
prashantwason commented on a change in pull request #2701: URL: https://github.com/apache/hudi/pull/2701#discussion_r663193484 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/upgrade/TwoToOneDowngradeHandler.java ## @@ -0,0 +1,66 @@ +/* + *

[GitHub] [hudi] prashantwason commented on a change in pull request #2701: [HUDI 1623] New Hoodie Instant on disk format with end time and milliseconds granularity

2021-07-02 Thread GitBox
prashantwason commented on a change in pull request #2701: URL: https://github.com/apache/hudi/pull/2701#discussion_r663193163 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/upgrade/TwoToOneDowngradeHandler.java ## @@ -0,0 +1,66 @@ +/* + *

[GitHub] [hudi] prashantwason commented on a change in pull request #2701: [HUDI 1623] New Hoodie Instant on disk format with end time and milliseconds granularity

2021-07-02 Thread GitBox
prashantwason commented on a change in pull request #2701: URL: https://github.com/apache/hudi/pull/2701#discussion_r663192171 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/upgrade/TwoToOneDowngradeHandler.java ## @@ -0,0 +1,66 @@ +/* + *

[GitHub] [hudi] prashantwason commented on a change in pull request #2701: [HUDI 1623] New Hoodie Instant on disk format with end time and milliseconds granularity

2021-07-02 Thread GitBox
prashantwason commented on a change in pull request #2701: URL: https://github.com/apache/hudi/pull/2701#discussion_r663192034 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/upgrade/TwoToOneDowngradeHandler.java ## @@ -0,0 +1,66 @@ +/* + *

[GitHub] [hudi] prashantwason commented on a change in pull request #2701: [HUDI 1623] New Hoodie Instant on disk format with end time and milliseconds granularity

2021-07-02 Thread GitBox
prashantwason commented on a change in pull request #2701: URL: https://github.com/apache/hudi/pull/2701#discussion_r663175716 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstant.java ## @@ -183,25 +183,30 @@ public boolean

[GitHub] [hudi] prashantwason commented on a change in pull request #2701: [HUDI 1623] New Hoodie Instant on disk format with end time and milliseconds granularity

2021-07-02 Thread GitBox
prashantwason commented on a change in pull request #2701: URL: https://github.com/apache/hudi/pull/2701#discussion_r663174457 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstant.java ## @@ -71,46 +72,75 @@ public static String

[GitHub] [hudi] prashantwason commented on a change in pull request #2701: [HUDI 1623] New Hoodie Instant on disk format with end time and milliseconds granularity

2021-07-02 Thread GitBox
prashantwason commented on a change in pull request #2701: URL: https://github.com/apache/hudi/pull/2701#discussion_r663173263 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstant.java ## @@ -71,46 +72,75 @@ public static String

[GitHub] [hudi] prashantwason commented on a change in pull request #2701: [HUDI 1623] New Hoodie Instant on disk format with end time and milliseconds granularity

2021-07-02 Thread GitBox
prashantwason commented on a change in pull request #2701: URL: https://github.com/apache/hudi/pull/2701#discussion_r663169602 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimelineLayout.java ## @@ -55,6 +58,11 @@ public static TimelineLayout

[GitHub] [hudi] prashantwason commented on a change in pull request #2701: [HUDI 1623] New Hoodie Instant on disk format with end time and milliseconds granularity

2021-07-02 Thread GitBox
prashantwason commented on a change in pull request #2701: URL: https://github.com/apache/hudi/pull/2701#discussion_r663169602 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimelineLayout.java ## @@ -55,6 +58,11 @@ public static TimelineLayout

[GitHub] [hudi] prashantwason commented on a change in pull request #2701: [HUDI 1623] New Hoodie Instant on disk format with end time and milliseconds granularity

2021-07-02 Thread GitBox
prashantwason commented on a change in pull request #2701: URL: https://github.com/apache/hudi/pull/2701#discussion_r663169332 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimelineLayout.java ## @@ -74,5 +82,26 @@ public static TimelineLayout

[GitHub] [hudi] prashantwason commented on a change in pull request #2701: [HUDI 1623] New Hoodie Instant on disk format with end time and milliseconds granularity

2021-07-02 Thread GitBox
prashantwason commented on a change in pull request #2701: URL: https://github.com/apache/hudi/pull/2701#discussion_r663168358 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/HoodieInstantVersion.java ## @@ -0,0 +1,62 @@ +/* + *

[GitHub] [hudi] prashantwason commented on a change in pull request #2701: [HUDI 1623] New Hoodie Instant on disk format with end time and milliseconds granularity

2021-07-02 Thread GitBox
prashantwason commented on a change in pull request #2701: URL: https://github.com/apache/hudi/pull/2701#discussion_r663166378 ## File path: hudi-common/src/test/java/org/apache/hudi/common/table/timeline/TestHoodieActiveTimeline.java ## @@ -350,11 +350,8 @@ public void

[GitHub] [hudi] prashantwason commented on a change in pull request #2701: [HUDI 1623] New Hoodie Instant on disk format with end time and milliseconds granularity

2021-06-25 Thread GitBox
prashantwason commented on a change in pull request #2701: URL: https://github.com/apache/hudi/pull/2701#discussion_r658951164 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/upgrade/TwoToOneDowngradeHandler.java ## @@ -0,0 +1,66 @@ +/* + *