[GitHub] [hudi] prashantwason commented on a diff in pull request #8523: [HUDI-6114] Fixed rollback of blocks in scanInternalV1

2023-04-27 Thread via GitHub
prashantwason commented on code in PR #8523: URL: https://github.com/apache/hudi/pull/8523#discussion_r1178663188 ## hudi-common/src/test/java/org/apache/hudi/common/functional/TestHoodieLogFormat.java: ## @@ -2718,4 +2595,40 @@ private HoodieLogFormat.Reader

[GitHub] [hudi] prashantwason commented on a diff in pull request #8523: [HUDI-6114] Fixed rollback of blocks in scanInternalV1

2023-04-26 Thread via GitHub
prashantwason commented on code in PR #8523: URL: https://github.com/apache/hudi/pull/8523#discussion_r1178653357 ## hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordReader.java: ## @@ -306,45 +306,43 @@ private void scanInternalV1(Option