[GitHub] [hudi] prashantwason commented on a diff in pull request #8837: [HUDI-6153] Changed the rollback mechanism for MDT to actual rollbacks rather than appending revert blocks.

2023-07-18 Thread via GitHub
prashantwason commented on code in PR #8837: URL: https://github.com/apache/hudi/pull/8837#discussion_r1266731173 ## hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java: ## @@ -742,8 +750,10 @@ private static List

[GitHub] [hudi] prashantwason commented on a diff in pull request #8837: [HUDI-6153] Changed the rollback mechanism for MDT to actual rollbacks rather than appending revert blocks.

2023-07-18 Thread via GitHub
prashantwason commented on code in PR #8837: URL: https://github.com/apache/hudi/pull/8837#discussion_r1266720620 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -910,26 +914,25 @@ public void

[GitHub] [hudi] prashantwason commented on a diff in pull request #8837: [HUDI-6153] Changed the rollback mechanism for MDT to actual rollbacks rather than appending revert blocks.

2023-07-18 Thread via GitHub
prashantwason commented on code in PR #8837: URL: https://github.com/apache/hudi/pull/8837#discussion_r1266694440 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -1019,14 +1016,23 @@ public void

[GitHub] [hudi] prashantwason commented on a diff in pull request #8837: [HUDI-6153] Changed the rollback mechanism for MDT to actual rollbacks rather than appending revert blocks.

2023-07-18 Thread via GitHub
prashantwason commented on code in PR #8837: URL: https://github.com/apache/hudi/pull/8837#discussion_r1245896736 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -966,8 +966,8 @@ public void

[GitHub] [hudi] prashantwason commented on a diff in pull request #8837: [HUDI-6153] Changed the rollback mechanism for MDT to actual rollbacks rather than appending revert blocks.

2023-06-28 Thread via GitHub
prashantwason commented on code in PR #8837: URL: https://github.com/apache/hudi/pull/8837#discussion_r1245811595 ## hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java: ## @@ -625,6 +625,9 @@ private static void

[GitHub] [hudi] prashantwason commented on a diff in pull request #8837: [HUDI-6153] Changed the rollback mechanism for MDT to actual rollbacks rather than appending revert blocks.

2023-06-28 Thread via GitHub
prashantwason commented on code in PR #8837: URL: https://github.com/apache/hudi/pull/8837#discussion_r1245811085 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java: ## @@ -669,32 +669,51 @@ public void restoreToSavepoint() { *

[GitHub] [hudi] prashantwason commented on a diff in pull request #8837: [HUDI-6153] Changed the rollback mechanism for MDT to actual rollbacks rather than appending revert blocks.

2023-06-28 Thread via GitHub
prashantwason commented on code in PR #8837: URL: https://github.com/apache/hudi/pull/8837#discussion_r1245809621 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java: ## @@ -669,32 +669,51 @@ public void restoreToSavepoint() { *

[GitHub] [hudi] prashantwason commented on a diff in pull request #8837: [HUDI-6153] Changed the rollback mechanism for MDT to actual rollbacks rather than appending revert blocks.

2023-06-28 Thread via GitHub
prashantwason commented on code in PR #8837: URL: https://github.com/apache/hudi/pull/8837#discussion_r1245808678 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java: ## @@ -669,32 +669,51 @@ public void restoreToSavepoint() { *

[GitHub] [hudi] prashantwason commented on a diff in pull request #8837: [HUDI-6153] Changed the rollback mechanism for MDT to actual rollbacks rather than appending revert blocks.

2023-06-28 Thread via GitHub
prashantwason commented on code in PR #8837: URL: https://github.com/apache/hudi/pull/8837#discussion_r1245807148 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -851,26 +919,49 @@ public void

[GitHub] [hudi] prashantwason commented on a diff in pull request #8837: [HUDI-6153] Changed the rollback mechanism for MDT to actual rollbacks rather than appending revert blocks.

2023-06-28 Thread via GitHub
prashantwason commented on code in PR #8837: URL: https://github.com/apache/hudi/pull/8837#discussion_r1245804286 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -851,26 +919,49 @@ public void

[GitHub] [hudi] prashantwason commented on a diff in pull request #8837: [HUDI-6153] Changed the rollback mechanism for MDT to actual rollbacks rather than appending revert blocks.

2023-06-28 Thread via GitHub
prashantwason commented on code in PR #8837: URL: https://github.com/apache/hudi/pull/8837#discussion_r1245803629 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -837,10 +840,75 @@ public void

[GitHub] [hudi] prashantwason commented on a diff in pull request #8837: [HUDI-6153] Changed the rollback mechanism for MDT to actual rollbacks rather than appending revert blocks.

2023-06-28 Thread via GitHub
prashantwason commented on code in PR #8837: URL: https://github.com/apache/hudi/pull/8837#discussion_r1245802921 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -837,10 +840,75 @@ public void

[GitHub] [hudi] prashantwason commented on a diff in pull request #8837: [HUDI-6153] Changed the rollback mechanism for MDT to actual rollbacks rather than appending revert blocks.

2023-06-28 Thread via GitHub
prashantwason commented on code in PR #8837: URL: https://github.com/apache/hudi/pull/8837#discussion_r1245801386 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -837,10 +840,75 @@ public void

[GitHub] [hudi] prashantwason commented on a diff in pull request #8837: [HUDI-6153] Changed the rollback mechanism for MDT to actual rollbacks rather than appending revert blocks.

2023-06-05 Thread via GitHub
prashantwason commented on code in PR #8837: URL: https://github.com/apache/hudi/pull/8837#discussion_r1218525849 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -851,26 +919,49 @@ public void

[GitHub] [hudi] prashantwason commented on a diff in pull request #8837: [HUDI-6153] Changed the rollback mechanism for MDT to actual rollbacks rather than appending revert blocks.

2023-06-05 Thread via GitHub
prashantwason commented on code in PR #8837: URL: https://github.com/apache/hudi/pull/8837#discussion_r1218524723 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -837,10 +840,75 @@ public void

[GitHub] [hudi] prashantwason commented on a diff in pull request #8837: [HUDI-6153] Changed the rollback mechanism for MDT to actual rollbacks rather than appending revert blocks.

2023-06-01 Thread via GitHub
prashantwason commented on code in PR #8837: URL: https://github.com/apache/hudi/pull/8837#discussion_r1213476749 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -851,26 +919,49 @@ public void

[GitHub] [hudi] prashantwason commented on a diff in pull request #8837: [HUDI-6153] Changed the rollback mechanism for MDT to actual rollbacks rather than appending revert blocks.

2023-06-01 Thread via GitHub
prashantwason commented on code in PR #8837: URL: https://github.com/apache/hudi/pull/8837#discussion_r1213473799 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -837,10 +840,75 @@ public void

[GitHub] [hudi] prashantwason commented on a diff in pull request #8837: [HUDI-6153] Changed the rollback mechanism for MDT to actual rollbacks rather than appending revert blocks.

2023-06-01 Thread via GitHub
prashantwason commented on code in PR #8837: URL: https://github.com/apache/hudi/pull/8837#discussion_r1213473799 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -837,10 +840,75 @@ public void

[GitHub] [hudi] prashantwason commented on a diff in pull request #8837: [HUDI-6153] Changed the rollback mechanism for MDT to actual rollbacks rather than appending revert blocks.

2023-06-01 Thread via GitHub
prashantwason commented on code in PR #8837: URL: https://github.com/apache/hudi/pull/8837#discussion_r1213470892 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java: ## @@ -669,32 +669,51 @@ public void restoreToSavepoint() { *