[GitHub] [hudi] pratyakshsharma commented on pull request #2768: [HUDI-485]: corrected the check for incremental sql

2022-01-11 Thread GitBox
pratyakshsharma commented on pull request #2768: URL: https://github.com/apache/hudi/pull/2768#issuecomment-1010233477 @codope please take a pass, I have added the happy flow test case now. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hudi] pratyakshsharma commented on pull request #2768: [HUDI-485]: corrected the check for incremental sql

2021-12-21 Thread GitBox
pratyakshsharma commented on pull request #2768: URL: https://github.com/apache/hudi/pull/2768#issuecomment-998847315 @nsivabalan @vinothchandar please take a pass. We can include this in 0.10.1 release as well. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hudi] pratyakshsharma commented on pull request #2768: [HUDI-485]: corrected the check for incremental sql

2021-12-20 Thread GitBox
pratyakshsharma commented on pull request #2768: URL: https://github.com/apache/hudi/pull/2768#issuecomment-998481547 Ack. Let me close this in a day or two. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [hudi] pratyakshsharma commented on pull request #2768: [HUDI-485]: corrected the check for incremental sql

2021-09-12 Thread GitBox
pratyakshsharma commented on pull request #2768: URL: https://github.com/apache/hudi/pull/2768#issuecomment-917663397 @codope I need to add few test cases for this PR. Will do that soon! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hudi] pratyakshsharma commented on pull request #2768: [HUDI-485]: corrected the check for incremental sql

2021-05-29 Thread GitBox
pratyakshsharma commented on pull request #2768: URL: https://github.com/apache/hudi/pull/2768#issuecomment-850885803 > @vingov for an extra pair of eyes. @pratyakshsharma any testing done for the PR? any way to add a test for the tool? No I have not done any testing. Currently there