[GitHub] [hudi] sandyfog commented on a diff in pull request #7886: [HUDI-5726] Fix timestamp field is 8 hours longer than the time

2023-02-27 Thread via GitHub
sandyfog commented on code in PR #7886: URL: https://github.com/apache/hudi/pull/7886#discussion_r1118529786 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/AvroToRowDataConverters.java: ## @@ -233,7 +234,9 @@ private static AvroToRowDataConverter createT

[GitHub] [hudi] sandyfog commented on a diff in pull request #7886: [HUDI-5726] Fix timestamp field is 8 hours longer than the time

2023-02-26 Thread via GitHub
sandyfog commented on code in PR #7886: URL: https://github.com/apache/hudi/pull/7886#discussion_r1118359501 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/AvroToRowDataConverters.java: ## @@ -233,7 +234,9 @@ private static AvroToRowDataConverter createT

[GitHub] [hudi] sandyfog commented on a diff in pull request #7886: [HUDI-5726] Fix timestamp field is 8 hours longer than the time

2023-02-25 Thread via GitHub
sandyfog commented on code in PR #7886: URL: https://github.com/apache/hudi/pull/7886#discussion_r1118011841 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/AvroToRowDataConverters.java: ## @@ -233,7 +234,9 @@ private static AvroToRowDataConverter createT

[GitHub] [hudi] sandyfog commented on a diff in pull request #7886: [HUDI-5726]Fix timestamp field is 8 hours longer than the time

2023-02-13 Thread via GitHub
sandyfog commented on code in PR #7886: URL: https://github.com/apache/hudi/pull/7886#discussion_r1104494581 ## hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/RowDataParquetWriteSupport.java: ## @@ -53,7 +53,7 @@ public WriteContext init(Configuration

[GitHub] [hudi] sandyfog commented on a diff in pull request #7886: [HUDI-5726]Fix timestamp field is 8 hours longer than the time

2023-02-11 Thread via GitHub
sandyfog commented on code in PR #7886: URL: https://github.com/apache/hudi/pull/7886#discussion_r1103596343 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java: ## @@ -275,7 +275,7 @@ private FlinkOptions() { public static final

[GitHub] [hudi] sandyfog commented on a diff in pull request #7886: [HUDI-5726]Fix timestamp field is 8 hours longer than the time

2023-02-09 Thread via GitHub
sandyfog commented on code in PR #7886: URL: https://github.com/apache/hudi/pull/7886#discussion_r1102245302 ## hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/ITTestHoodieDataSource.java: ## @@ -1693,6 +1693,121 @@ void testWriteReadWithLocalTimestamp(Hoodi

[GitHub] [hudi] sandyfog commented on a diff in pull request #7886: [HUDI-5726]Fix timestamp field is 8 hours longer than the time

2023-02-07 Thread via GitHub
sandyfog commented on code in PR #7886: URL: https://github.com/apache/hudi/pull/7886#discussion_r1099726331 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java: ## @@ -275,7 +275,7 @@ private FlinkOptions() { public static final