[GitHub] [hudi] slfan1989 commented on a diff in pull request #8478: [HUDI-6086] Improve HiveSchemaUtil#generateCreateDDL With StringBuilder

slfan1989 commented on code in PR #8478: URL: https://github.com/apache/hudi/pull/8478#discussion_r1192283013 ## hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/util/TestHiveSchemaUtil.java: ## @@ -145,4 +145,11 @@ public void testSchemaDiffForTimestampMicros() {

[GitHub] [hudi] slfan1989 commented on a diff in pull request #8478: [HUDI-6086] Improve HiveSchemaUtil#generateCreateDDL With StringBuilder

slfan1989 commented on code in PR #8478: URL: https://github.com/apache/hudi/pull/8478#discussion_r1183513185 ## hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/ddl/QueryBasedDDLExecutor.java: ## @@ -76,22 +77,41 @@ public QueryBasedDDLExecutor(HiveSyncConfig config)

[GitHub] [hudi] slfan1989 commented on a diff in pull request #8478: [HUDI-6086] Improve HiveSchemaUtil#generateCreateDDL With StringBuilder

slfan1989 commented on code in PR #8478: URL: https://github.com/apache/hudi/pull/8478#discussion_r1181553985 ## hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/util/HiveSchemaUtil.java: ## @@ -65,6 +67,34 @@ public class HiveSchemaUtil { public static final Strin