[GitHub] [hudi] stream2000 commented on a diff in pull request #8745: [HUDI-6182] Hive sync use state transient time to avoid losing partit…

2023-06-07 Thread via GitHub
stream2000 commented on code in PR #8745: URL: https://github.com/apache/hudi/pull/8745#discussion_r1221421300 ## hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HoodieHiveSyncClient.java: ## @@ -341,8 +353,15 @@ public void close() { @Override public void upda

[GitHub] [hudi] stream2000 commented on a diff in pull request #8745: [HUDI-6182] Hive sync use state transient time to avoid losing partit…

2023-06-06 Thread via GitHub
stream2000 commented on code in PR #8745: URL: https://github.com/apache/hudi/pull/8745#discussion_r1219271382 ## hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java: ## @@ -298,6 +298,22 @@ protected void syncHoodieTable(String tableName, boolean useR

[GitHub] [hudi] stream2000 commented on a diff in pull request #8745: [HUDI-6182] Hive sync use state transient time to avoid losing partit…

2023-06-05 Thread via GitHub
stream2000 commented on code in PR #8745: URL: https://github.com/apache/hudi/pull/8745#discussion_r1218852843 ## hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java: ## @@ -298,6 +298,22 @@ protected void syncHoodieTable(String tableName, boolean useR

[GitHub] [hudi] stream2000 commented on a diff in pull request #8745: [HUDI-6182] Hive sync use state transient time to avoid losing partit…

2023-06-01 Thread via GitHub
stream2000 commented on code in PR #8745: URL: https://github.com/apache/hudi/pull/8745#discussion_r1213873676 ## hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java: ## @@ -298,6 +298,22 @@ protected void syncHoodieTable(String tableName, boolean useR

[GitHub] [hudi] stream2000 commented on a diff in pull request #8745: [HUDI-6182] Hive sync use state transient time to avoid losing partit…

2023-06-01 Thread via GitHub
stream2000 commented on code in PR #8745: URL: https://github.com/apache/hudi/pull/8745#discussion_r1213840107 ## hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java: ## @@ -298,6 +298,22 @@ protected void syncHoodieTable(String tableName, boolean useR

[GitHub] [hudi] stream2000 commented on a diff in pull request #8745: [HUDI-6182] Hive sync use state transient time to avoid losing partit…

2023-05-17 Thread via GitHub
stream2000 commented on code in PR #8745: URL: https://github.com/apache/hudi/pull/8745#discussion_r1197325515 ## hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimelineUtils.java: ## @@ -234,6 +234,21 @@ public static HoodieTimeline getCommitsTimelineAfter(