[GitHub] [hudi] umehrot2 commented on pull request #1702: [HUDI-426] Bootstrap datasource integration

2020-08-08 Thread GitBox
umehrot2 commented on pull request #1702: URL: https://github.com/apache/hudi/pull/1702#issuecomment-670963669 > @umehrot2 : Can you confirm if all review comments are resolved and the PR is ready otherwise. @bvaradar Thanks for taking a look. Yes the other PR comments are

[GitHub] [hudi] umehrot2 commented on pull request #1702: [HUDI-426] Bootstrap datasource integration

2020-08-07 Thread GitBox
umehrot2 commented on pull request #1702: URL: https://github.com/apache/hudi/pull/1702#issuecomment-670814850 @vinothchandar the unit tests issues are resolved now. But the integration tests are behaving crazy. They passed the last time, and failed now even though I didn't make any code

[GitHub] [hudi] umehrot2 commented on pull request #1702: [HUDI-426] Bootstrap datasource integration

2020-08-07 Thread GitBox
umehrot2 commented on pull request #1702: URL: https://github.com/apache/hudi/pull/1702#issuecomment-670793211 @vinothchandar I fixed the rebase issue, and resolved the `bootstrap` related test failures. I still see `MOR data source` related unit test failures because of `spark context`.

[GitHub] [hudi] umehrot2 commented on pull request #1702: [HUDI-426] Bootstrap datasource integration

2020-08-07 Thread GitBox
umehrot2 commented on pull request #1702: URL: https://github.com/apache/hudi/pull/1702#issuecomment-670717238 > @umehrot2 some tests are failing . looking at them later today. > > Before we head into the weekend, is this PR ready from your perspective. if so, I will take care of

[GitHub] [hudi] umehrot2 commented on pull request #1702: [HUDI-426] Bootstrap datasource integration

2020-08-04 Thread GitBox
umehrot2 commented on pull request #1702: URL: https://github.com/apache/hudi/pull/1702#issuecomment-668972215 @vinothchandar the tests are passing, so its ready for review from my side. This is an automated message from the

[GitHub] [hudi] umehrot2 commented on pull request #1702: [HUDI-426] Bootstrap datasource integration

2020-08-04 Thread GitBox
umehrot2 commented on pull request #1702: URL: https://github.com/apache/hudi/pull/1702#issuecomment-668860202 > @umehrot2 heads up, we could be landing #1848 before this. (CI willing). How hard would the rebase be. I assume there would be some extra work to integrate? I guess one