[GitHub] [hudi] vingov commented on pull request #2747: [HUDI-1743] Added support for SqlFileBasedTransformer

2021-06-06 Thread GitBox
vingov commented on pull request #2747: URL: https://github.com/apache/hudi/pull/2747#issuecomment-855352726 @nsivabalan - Addressed all the feedback, please review and merge this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hudi] vingov commented on pull request #2747: [HUDI-1743] Added support for SqlFileBasedTransformer

2021-04-25 Thread GitBox
vingov commented on pull request #2747: URL: https://github.com/apache/hudi/pull/2747#issuecomment-826157848 @yanghua - I have added the unit tests, Can you please review and merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [hudi] vingov commented on pull request #2747: [HUDI-1743] Added support for SqlFileBasedTransformer

2021-04-24 Thread GitBox
vingov commented on pull request #2747: URL: https://github.com/apache/hudi/pull/2747#issuecomment-826157848 @yanghua - I have added the unit tests, Can you please review and merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [hudi] vingov commented on pull request #2747: [HUDI-1743] Added support for SqlFileBasedTransformer

2021-04-07 Thread GitBox
vingov commented on pull request #2747: URL: https://github.com/apache/hudi/pull/2747#issuecomment-815167427 @yanghua - I don't see the unit tests for the existing transformers except for two functions, I don't have time now to write unit tests, can I handle it in a separate pull request w

[GitHub] [hudi] vingov commented on pull request #2747: [HUDI-1743] Added support for SqlFileBasedTransformer

2021-03-31 Thread GitBox
vingov commented on pull request #2747: URL: https://github.com/apache/hudi/pull/2747#issuecomment-811654731 @yanghua - I've fixed the build, can you please merge this code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and