vingov commented on pull request #2768:
URL: https://github.com/apache/hudi/pull/2768#issuecomment-915662329
the code looks good, my last comment was confirming that we should use '%s'
so that the String.format function in the L197 will replace it correctly.
No further changes are re
vingov commented on pull request #2768:
URL: https://github.com/apache/hudi/pull/2768#issuecomment-822978140
lgtm, we should use '%s' to replace the from commit time in the line no. 197
with the string format function:
`incrementalPullSQLtemplate.add("incrementalSQL",
String.format(
