[GitHub] [hudi] voonhous commented on a diff in pull request #8501: [HUDI-6103] Validate required columns when fetching required positions

2023-04-26 Thread via GitHub
voonhous commented on code in PR #8501: URL: https://github.com/apache/hudi/pull/8501#discussion_r1178169075 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableFactory.java: ## @@ -401,4 +408,35 @@ private static void

[GitHub] [hudi] voonhous commented on a diff in pull request #8501: [HUDI-6103] Validate required columns when fetching required positions

2023-04-26 Thread via GitHub
voonhous commented on code in PR #8501: URL: https://github.com/apache/hudi/pull/8501#discussion_r1177710126 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableFactory.java: ## @@ -401,4 +408,35 @@ private static void

[GitHub] [hudi] voonhous commented on a diff in pull request #8501: [HUDI-6103] Validate required columns when fetching required positions

2023-04-26 Thread via GitHub
voonhous commented on code in PR #8501: URL: https://github.com/apache/hudi/pull/8501#discussion_r1177685237 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableFactory.java: ## @@ -401,4 +408,35 @@ private static void

[GitHub] [hudi] voonhous commented on a diff in pull request #8501: [HUDI-6103] Validate required columns when fetching required positions

2023-04-20 Thread via GitHub
voonhous commented on code in PR #8501: URL: https://github.com/apache/hudi/pull/8501#discussion_r1172381928 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/mor/MergeOnReadTableState.java: ## @@ -85,7 +86,7 @@ public int getOperationPos() {

[GitHub] [hudi] voonhous commented on a diff in pull request #8501: [HUDI-6103] Validate required columns when fetching required positions

2023-04-20 Thread via GitHub
voonhous commented on code in PR #8501: URL: https://github.com/apache/hudi/pull/8501#discussion_r1172362684 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/mor/MergeOnReadTableState.java: ## @@ -85,7 +86,7 @@ public int getOperationPos() {

[GitHub] [hudi] voonhous commented on a diff in pull request #8501: [HUDI-6103] Validate required columns when fetching required positions

2023-04-19 Thread via GitHub
voonhous commented on code in PR #8501: URL: https://github.com/apache/hudi/pull/8501#discussion_r1172090557 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/mor/MergeOnReadTableState.java: ## @@ -85,7 +86,7 @@ public int getOperationPos() {