[GitHub] [hudi] voonhous commented on pull request #7480: [HUDI-5400] Fix read issues when Hudi-FULL schema evolution is not enabled

2022-12-22 Thread GitBox
voonhous commented on PR #7480: URL: https://github.com/apache/hudi/pull/7480#issuecomment-1362665267 > @voonhous Thank you for your support for spark2.4, although I personally think we don't need to support 2.4. let‘s extract buildImplicitSchemaChangeInfo and isDataTypeEqual to a helper cl

[GitHub] [hudi] voonhous commented on pull request #7480: [HUDI-5400] Fix read issues when Hudi-FULL schema evolution is not enabled

2022-12-21 Thread GitBox
voonhous commented on PR #7480: URL: https://github.com/apache/hudi/pull/7480#issuecomment-1362461598 @xiarixiaoyao I have added support for Hudi tables that are schema-evolved via ASR for Spark2.4. Can you please help to review the PR again? Thank you! -- This is an autom

[GitHub] [hudi] voonhous commented on pull request #7480: [HUDI-5400] Fix read issues when Hudi-FULL schema evolution is not enabled

2022-12-20 Thread GitBox
voonhous commented on PR #7480: URL: https://github.com/apache/hudi/pull/7480#issuecomment-1360814665 > @voonhous pls rebase code, once ci pass,we can merge it . Done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hudi] voonhous commented on pull request #7480: [HUDI-5400] Fix read issues when Hudi-FULL schema evolution is not enabled

2022-12-20 Thread GitBox
voonhous commented on PR #7480: URL: https://github.com/apache/hudi/pull/7480#issuecomment-1360786269 > > @voonhous Maybe we need a parameter to control this feature, not all tables need to follow this logic > > Hmmm, CMIIW, Hudi has been relying on ASR for schema resolution since `h

[GitHub] [hudi] voonhous commented on pull request #7480: [HUDI-5400] Fix read issues when Hudi-FULL schema evolution is not enabled

2022-12-20 Thread GitBox
voonhous commented on PR #7480: URL: https://github.com/apache/hudi/pull/7480#issuecomment-1359140661 > @voonhous Maybe we need a parameter to control this feature, not all tables need to follow this logic Hmmm, CMIIW, Hudi has been relying on ASR for schema resolution since Hudi-0.7