[GitHub] [hudi] wzx140 commented on a diff in pull request #7021: [Minor] fix multi deser avro payload

2022-11-20 Thread GitBox
wzx140 commented on code in PR #7021: URL: https://github.com/apache/hudi/pull/7021#discussion_r1027290671 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java: ## @@ -364,7 +364,8 @@ private void processAppendResult(AppendResult result, Li

[GitHub] [hudi] wzx140 commented on a diff in pull request #7021: [Minor] fix multi deser avro payload

2022-11-20 Thread GitBox
wzx140 commented on code in PR #7021: URL: https://github.com/apache/hudi/pull/7021#discussion_r1027289037 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java: ## @@ -215,18 +216,16 @@ private Option prepareRecord(HoodieRecord hoodieRecord

[GitHub] [hudi] wzx140 commented on a diff in pull request #7021: [Minor] fix multi deser avro payload

2022-11-16 Thread GitBox
wzx140 commented on code in PR #7021: URL: https://github.com/apache/hudi/pull/7021#discussion_r1024786040 ## hudi-common/src/main/java/org/apache/hudi/common/model/HoodieAvroRecord.java: ## @@ -133,23 +143,29 @@ public HoodieRecord updateMetadataValues(Schema recordSchema, Pro

[GitHub] [hudi] wzx140 commented on a diff in pull request #7021: [Minor] fix multi deser avro payload

2022-10-24 Thread GitBox
wzx140 commented on code in PR #7021: URL: https://github.com/apache/hudi/pull/7021#discussion_r1003952529 ## hudi-common/src/main/java/org/apache/hudi/common/model/HoodieAvroRecord.java: ## @@ -189,14 +193,37 @@ public Option> getMetadata() { @Override public Option toI