[GitHub] [hudi] xiarixiaoyao commented on pull request #4013: [HUDI-2778] Optimize statistics collection related codes and add some docs for z-order add fix some bugs

2021-11-22 Thread GitBox
xiarixiaoyao commented on pull request #4013: URL: https://github.com/apache/hudi/pull/4013#issuecomment-976120008 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [hudi] xiarixiaoyao commented on pull request #4013: [HUDI-2778] Optimize statistics collection related codes and add some docs for z-order add fix some bugs

2021-11-22 Thread GitBox
xiarixiaoyao commented on pull request #4013: URL: https://github.com/apache/hudi/pull/4013#issuecomment-976114333 @vinothchandar Yes, there are a lot of repetitive work at present. I'm very sorry for this. This series of problems are caused by the inconsistency between my local

[GitHub] [hudi] xiarixiaoyao commented on pull request #4013: [HUDI-2778] Optimize statistics collection related codes and add some docs for z-order add fix some bugs

2021-11-22 Thread GitBox
xiarixiaoyao commented on pull request #4013: URL: https://github.com/apache/hudi/pull/4013#issuecomment-975477611 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [hudi] xiarixiaoyao commented on pull request #4013: [HUDI-2778] Optimize statistics collection related codes and add some docs for z-order add fix some bugs

2021-11-22 Thread GitBox
xiarixiaoyao commented on pull request #4013: URL: https://github.com/apache/hudi/pull/4013#issuecomment-975382023 @leesf addressed all commts, add UT for multi-thread parquet footer read -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hudi] xiarixiaoyao commented on pull request #4013: [HUDI-2778] Optimize statistics collection related codes and add some docs for z-order add fix some bugs

2021-11-21 Thread GitBox
xiarixiaoyao commented on pull request #4013: URL: https://github.com/apache/hudi/pull/4013#issuecomment-975161713 @vinothchandar @leesf @alexeykudinkin could we merge this patch to master? this patch can solve most of the problems in #4026 and #4060 -- This is an automated message

[GitHub] [hudi] xiarixiaoyao commented on pull request #4013: [HUDI-2778] Optimize statistics collection related codes and add some docs for z-order add fix some bugs

2021-11-21 Thread GitBox
xiarixiaoyao commented on pull request #4013: URL: https://github.com/apache/hudi/pull/4013#issuecomment-975160541 @leesf we can build indexes for Dataskipping Manually。 step1: we can use ZCurveOptimizeHelper.getMinMaxValue to get min-max statistics info for current table ste2: u

[GitHub] [hudi] xiarixiaoyao commented on pull request #4013: [HUDI-2778] Optimize statistics collection related codes and add some docs for z-order add fix some bugs

2021-11-21 Thread GitBox
xiarixiaoyao commented on pull request #4013: URL: https://github.com/apache/hudi/pull/4013#issuecomment-974766598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [hudi] xiarixiaoyao commented on pull request #4013: [HUDI-2778] Optimize statistics collection related codes and add some docs for z-order add fix some bugs

2021-11-20 Thread GitBox
xiarixiaoyao commented on pull request #4013: URL: https://github.com/apache/hudi/pull/4013#issuecomment-974767554 @leesf addressed all comments. thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [hudi] xiarixiaoyao commented on pull request #4013: [HUDI-2778] Optimize statistics collection related codes and add some docs for z-order add fix some bugs

2021-11-20 Thread GitBox
xiarixiaoyao commented on pull request #4013: URL: https://github.com/apache/hudi/pull/4013#issuecomment-974766598 @alexeykudinkin Thank you very much for your testing/bug fixing and code optimization. Due to the existence of rfc-27, data skipping was not considered too much in the ini

[GitHub] [hudi] xiarixiaoyao commented on pull request #4013: [HUDI-2778] Optimize statistics collection related codes and add some docs for z-order add fix some bugs

2021-11-17 Thread GitBox
xiarixiaoyao commented on pull request #4013: URL: https://github.com/apache/hudi/pull/4013#issuecomment-972589911 @leesf @vinothchandar @alexeykudinkin address all comments and update the codes and more test case. could you help me review this pr again , thanks. -- This is an