[GitHub] [hudi] xicm commented on a diff in pull request #7068: [HUDI-5096] boolean param is broken in HiveSyncTool

xicm commented on code in PR #7068: URL: https://github.com/apache/hudi/pull/7068#discussion_r1008996231 ## hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java: ## @@ -108,45 +108,45 @@ public static class HiveSyncConfigParams { + "instea

[GitHub] [hudi] xicm commented on a diff in pull request #7068: [HUDI-5096] boolean param is broken in HiveSyncTool

xicm commented on code in PR #7068: URL: https://github.com/apache/hudi/pull/7068#discussion_r1008721355 ## hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java: ## @@ -108,45 +108,45 @@ public static class HiveSyncConfigParams { + "instea

[GitHub] [hudi] xicm commented on a diff in pull request #7068: [HUDI-5096] boolean param is broken in HiveSyncTool

xicm commented on code in PR #7068: URL: https://github.com/apache/hudi/pull/7068#discussion_r1007668806 ## hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java: ## @@ -108,45 +108,45 @@ public static class HiveSyncConfigParams { + "instea

[GitHub] [hudi] xicm commented on a diff in pull request #7068: [HUDI-5096] boolean param is broken in HiveSyncTool

xicm commented on code in PR #7068: URL: https://github.com/apache/hudi/pull/7068#discussion_r1007556532 ## hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/replication/TestHiveSyncGlobalCommitTool.java: ## @@ -69,6 +70,7 @@ private HiveSyncGlobalCommitParams getGlob

[GitHub] [hudi] xicm commented on a diff in pull request #7068: [HUDI-5096] boolean param is broken in HiveSyncTool

xicm commented on code in PR #7068: URL: https://github.com/apache/hudi/pull/7068#discussion_r1007556414 ## hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java: ## @@ -108,45 +108,45 @@ public static class HiveSyncConfigParams { + "instea