[GitHub] [hudi] xicm commented on a diff in pull request #7226: [HUDI-5018] Make user-provided copyOnWriteRecordSizeEstimate first precedence

2022-11-22 Thread GitBox
xicm commented on code in PR #7226: URL: https://github.com/apache/hudi/pull/7226#discussion_r1029073719 ## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/UpsertPartitioner.java: ## @@ -367,9 +368,19 @@ public int getPartition(Object key) { /*

[GitHub] [hudi] xicm commented on a diff in pull request #7226: [HUDI-5018] Make user-provided copyOnWriteRecordSizeEstimate first precedence

2022-11-21 Thread GitBox
xicm commented on code in PR #7226: URL: https://github.com/apache/hudi/pull/7226#discussion_r1028925825 ## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/UpsertPartitioner.java: ## @@ -367,9 +368,19 @@ public int getPartition(Object key) { /*

[GitHub] [hudi] xicm commented on a diff in pull request #7226: [HUDI-5018] Make user-provided copyOnWriteRecordSizeEstimate first precedence

2022-11-20 Thread GitBox
xicm commented on code in PR #7226: URL: https://github.com/apache/hudi/pull/7226#discussion_r1027564734 ## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/UpsertPartitioner.java: ## @@ -367,9 +368,19 @@ public int getPartition(Object key) { /*