[GitHub] [hudi] xushiyan commented on a diff in pull request #6213: [HUDI-4081][HUDI-4472] Addressing Spark SQL vs Spark DS performance gap

2022-07-28 Thread GitBox
xushiyan commented on code in PR #6213: URL: https://github.com/apache/hudi/pull/6213#discussion_r932729471 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala: ## @@ -241,39 +240,49 @@ object HoodieSparkSqlWriter {

[GitHub] [hudi] xushiyan commented on a diff in pull request #6213: [HUDI-4081][HUDI-4472] Addressing Spark SQL vs Spark DS performance gap

2022-07-28 Thread GitBox
xushiyan commented on code in PR #6213: URL: https://github.com/apache/hudi/pull/6213#discussion_r932726718 ## hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/InsertIntoHoodieTableCommand.scala: ## @@ -66,103 +79,139 @@ object

[GitHub] [hudi] xushiyan commented on a diff in pull request #6213: [HUDI-4081][HUDI-4472] Addressing Spark SQL vs Spark DS performance gap

2022-07-28 Thread GitBox
xushiyan commented on code in PR #6213: URL: https://github.com/apache/hudi/pull/6213#discussion_r932713368 ## hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/InsertIntoHoodieTableCommand.scala: ## @@ -66,103 +79,139 @@ object