[GitHub] [hudi] xushiyan commented on a diff in pull request #6476: [HUDI-3478] Support CDC for Spark in Hudi

2022-09-07 Thread GitBox
xushiyan commented on code in PR #6476: URL: https://github.com/apache/hudi/pull/6476#discussion_r965411452 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java: ## @@ -399,9 +451,65 @@ protected void writeIncomingRecords() throws

[GitHub] [hudi] xushiyan commented on a diff in pull request #6476: [HUDI-3478] Support CDC for Spark in Hudi

2022-09-07 Thread GitBox
xushiyan commented on code in PR #6476: URL: https://github.com/apache/hudi/pull/6476#discussion_r956951504 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieSortedMergeHandle.java: ## @@ -116,12 +125,18 @@ public List close() { String key =

[GitHub] [hudi] xushiyan commented on a diff in pull request #6476: [HUDI-3478] Support CDC for Spark in Hudi

2022-08-29 Thread GitBox
xushiyan commented on code in PR #6476: URL: https://github.com/apache/hudi/pull/6476#discussion_r956897079 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java: ## @@ -465,23 +464,6 @@ public List writeStatuses() { return statuses;