[GitHub] [hudi] xushiyan commented on a diff in pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

2022-12-09 Thread GitBox
xushiyan commented on code in PR #7037: URL: https://github.com/apache/hudi/pull/7037#discussion_r1044630751 ## hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstant.java: ## @@ -67,7 +67,7 @@ public enum State { // Committed instant COMPLETED,

[GitHub] [hudi] xushiyan commented on a diff in pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

2022-12-08 Thread GitBox
xushiyan commented on code in PR #7037: URL: https://github.com/apache/hudi/pull/7037#discussion_r1044099173 ## hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstant.java: ## @@ -67,7 +67,7 @@ public enum State { // Committed instant COMPLETED,

[GitHub] [hudi] xushiyan commented on a diff in pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

2022-11-08 Thread GitBox
xushiyan commented on code in PR #7037: URL: https://github.com/apache/hudi/pull/7037#discussion_r1016342441 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/BaseActionExecutor.java: ## @@ -58,7 +59,7 @@ public BaseActionExecutor(HoodieEngineContext c

[GitHub] [hudi] xushiyan commented on a diff in pull request #7037: [HUDI-5078] Fixing determination of table service for metadata calls

2022-11-04 Thread GitBox
xushiyan commented on code in PR #7037: URL: https://github.com/apache/hudi/pull/7037#discussion_r1014078055 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java: ## @@ -858,10 +860,22 @@ public final Option getMetadataWriter(String triggeri