[GitHub] [hudi] xushiyan commented on a diff in pull request #8344: [HUDI-5968] Fix global index duplicate when update partition

xushiyan commented on code in PR #8344: URL: https://github.com/apache/hudi/pull/8344#discussion_r1156432021 ## hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieSimpleDataGenerator.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [hudi] xushiyan commented on a diff in pull request #8344: [HUDI-5968] Fix global index duplicate when update partition

xushiyan commented on code in PR #8344: URL: https://github.com/apache/hudi/pull/8344#discussion_r1156417851 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java: ## @@ -244,6 +244,12 @@ public class HoodieIndexConfig extends

[GitHub] [hudi] xushiyan commented on a diff in pull request #8344: [HUDI-5968] Fix global index duplicate when update partition

xushiyan commented on code in PR #8344: URL: https://github.com/apache/hudi/pull/8344#discussion_r1155185037 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/simple/HoodieGlobalSimpleIndex.java: ## @@ -135,8 +135,8 @@ private HoodieData> getTaggedRecords(