[GitHub] [hudi] xushiyan commented on a diff in pull request #8445: [HUDI-3088] Use Spark 3.2 as default Spark version

2023-05-25 Thread via GitHub
xushiyan commented on code in PR #8445: URL: https://github.com/apache/hudi/pull/8445#discussion_r1206146854 ## hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieDeltaStreamer.java: ## @@ -1946,8 +1947,8 @@ public void testJsonKafkaDFSSource()

[GitHub] [hudi] xushiyan commented on a diff in pull request #8445: [HUDI-3088] Use Spark 3.2 as default Spark version

2023-05-25 Thread via GitHub
xushiyan commented on code in PR #8445: URL: https://github.com/apache/hudi/pull/8445#discussion_r1205766323 ## pom.xml: ## @@ -1961,27 +1965,6 @@ - -org.jacoco -jacoco-maven-plugin - -

[GitHub] [hudi] xushiyan commented on a diff in pull request #8445: [HUDI-3088] Use Spark 3.2 as default Spark version

2023-05-25 Thread via GitHub
xushiyan commented on code in PR #8445: URL: https://github.com/apache/hudi/pull/8445#discussion_r1205766323 ## pom.xml: ## @@ -1961,27 +1965,6 @@ - -org.jacoco -jacoco-maven-plugin - -

[GitHub] [hudi] xushiyan commented on a diff in pull request #8445: [HUDI-3088] Use Spark 3.2 as default Spark version

2023-05-24 Thread via GitHub
xushiyan commented on code in PR #8445: URL: https://github.com/apache/hudi/pull/8445#discussion_r1204977620 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/index/hbase/TestSparkHoodieHBaseIndex.java: ## @@ -114,6 +114,9 @@ public class TestSparkHoodieHBaseIndex

[GitHub] [hudi] xushiyan commented on a diff in pull request #8445: [HUDI-3088] Use Spark 3.2 as default Spark version

2023-05-24 Thread via GitHub
xushiyan commented on code in PR #8445: URL: https://github.com/apache/hudi/pull/8445#discussion_r1204534014 ## hudi-integ-test/pom.xml: ## @@ -100,6 +98,21 @@ test + + + org.apache.parquet + parquet-avro + ${parquet.version} + test +

[GitHub] [hudi] xushiyan commented on a diff in pull request #8445: [HUDI-3088] Use Spark 3.2 as default Spark version

2023-05-24 Thread via GitHub
xushiyan commented on code in PR #8445: URL: https://github.com/apache/hudi/pull/8445#discussion_r1203804695 ## hudi-integ-test/pom.xml: ## @@ -100,6 +98,21 @@ test + + + org.apache.parquet + parquet-avro + ${parquet.version} + test +

[GitHub] [hudi] xushiyan commented on a diff in pull request #8445: [HUDI-3088] Use Spark 3.2 as default Spark version

2023-05-24 Thread via GitHub
xushiyan commented on code in PR #8445: URL: https://github.com/apache/hudi/pull/8445#discussion_r1203794976 ## hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieDeltaStreamer.java: ## @@ -1946,8 +1947,8 @@ public void testJsonKafkaDFSSource()

[GitHub] [hudi] xushiyan commented on a diff in pull request #8445: [HUDI-3088] Use Spark 3.2 as default Spark version

2023-05-24 Thread via GitHub
xushiyan commented on code in PR #8445: URL: https://github.com/apache/hudi/pull/8445#discussion_r1203786184 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/index/hbase/TestSparkHoodieHBaseIndex.java: ## @@ -114,6 +114,9 @@ public class TestSparkHoodieHBaseIndex

[GitHub] [hudi] xushiyan commented on a diff in pull request #8445: [HUDI-3088] Use Spark 3.2 as default Spark version

2023-05-23 Thread via GitHub
xushiyan commented on code in PR #8445: URL: https://github.com/apache/hudi/pull/8445#discussion_r1203466299 ## hudi-spark-datasource/hudi-spark3-common/src/test/java/org/apache/hudi/spark3/internal/TestHoodieDataSourceInternalBatchWrite.java: ## @@ -70,7 +71,7 @@ private

[GitHub] [hudi] xushiyan commented on a diff in pull request #8445: [HUDI-3088] Use Spark 3.2 as default Spark version

2023-05-23 Thread via GitHub
xushiyan commented on code in PR #8445: URL: https://github.com/apache/hudi/pull/8445#discussion_r1203463851 ## hudi-integ-test/pom.xml: ## @@ -100,6 +98,21 @@ test + + + org.apache.parquet + parquet-avro + ${parquet.version} + test +

[GitHub] [hudi] xushiyan commented on a diff in pull request #8445: [HUDI-3088] Use Spark 3.2 as default Spark version

2023-05-23 Thread via GitHub
xushiyan commented on code in PR #8445: URL: https://github.com/apache/hudi/pull/8445#discussion_r1203462529 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/index/hbase/TestSparkHoodieHBaseIndex.java: ## @@ -114,6 +114,9 @@ public class TestSparkHoodieHBaseIndex

[GitHub] [hudi] xushiyan commented on a diff in pull request #8445: [HUDI-3088] Use Spark 3.2 as default Spark version

2023-05-23 Thread via GitHub
xushiyan commented on code in PR #8445: URL: https://github.com/apache/hudi/pull/8445#discussion_r1203461726 ## hudi-client/hudi-client-common/src/test/java/org/apache/hudi/io/storage/TestHoodieHFileReaderWriter.java: ## @@ -198,10 +200,10 @@ public void

[GitHub] [hudi] xushiyan commented on a diff in pull request #8445: [HUDI-3088] Use Spark 3.2 as default Spark version

2023-05-23 Thread via GitHub
xushiyan commented on code in PR #8445: URL: https://github.com/apache/hudi/pull/8445#discussion_r1201928843 ## azure-pipelines-20230430.yml: ## @@ -220,39 +219,3 @@ stages: - script: | grep "testcase" */target/surefire-reports/*.xml

[GitHub] [hudi] xushiyan commented on a diff in pull request #8445: [HUDI-3088] Use Spark 3.2 as default Spark version

2023-05-23 Thread via GitHub
xushiyan commented on code in PR #8445: URL: https://github.com/apache/hudi/pull/8445#discussion_r1201889568 ## hudi-cli/pom.xml: ## @@ -246,6 +246,16 @@ org.apache.spark spark-core_${scala.binary.version} + + + org.apache.hadoop +

[GitHub] [hudi] xushiyan commented on a diff in pull request #8445: [HUDI-3088] Use Spark 3.2 as default Spark version

2023-05-23 Thread via GitHub
xushiyan commented on code in PR #8445: URL: https://github.com/apache/hudi/pull/8445#discussion_r1201885473 ## hudi-utilities/pom.xml: ## @@ -232,6 +232,14 @@ org.apache.spark spark-core_${scala.binary.version} + + org.apache.hadoop +