[GitHub] [hudi] xushiyan commented on a diff in pull request #8697: [HUDI-5514] Improving usability/performance with out of box default for append only use-cases

2023-08-02 Thread via GitHub
xushiyan commented on code in PR #8697: URL: https://github.com/apache/hudi/pull/8697#discussion_r1281457455 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala: ## @@ -429,6 +416,40 @@ object HoodieSparkSqlWriter { } }

[GitHub] [hudi] xushiyan commented on a diff in pull request #8697: [HUDI-5514] Improving usability/performance with out of box default for append only use-cases

2023-07-31 Thread via GitHub
xushiyan commented on code in PR #8697: URL: https://github.com/apache/hudi/pull/8697#discussion_r1280116139 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala: ## @@ -429,6 +416,40 @@ object HoodieSparkSqlWriter { } }

[GitHub] [hudi] xushiyan commented on a diff in pull request #8697: [HUDI-5514] Improving usability/performance with out of box default for append only use-cases

2023-07-05 Thread via GitHub
xushiyan commented on code in PR #8697: URL: https://github.com/apache/hudi/pull/8697#discussion_r1253031610 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala: ## @@ -402,6 +389,40 @@ object HoodieSparkSqlWriter { } }