[GitHub] [hudi] yanghua commented on a diff in pull request #6071: [HUDI-4065] Add FileBasedLockProvider

2022-07-18 Thread GitBox
yanghua commented on code in PR #6071: URL: https://github.com/apache/hudi/pull/6071#discussion_r923298238 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/FileSystemBasedLockProvider.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apach

[GitHub] [hudi] yanghua commented on a diff in pull request #6071: [HUDI-4065] Add FileBasedLockProvider

2022-07-16 Thread GitBox
yanghua commented on code in PR #6071: URL: https://github.com/apache/hudi/pull/6071#discussion_r922643570 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/FileSystemBasedLockProvider.java: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apach

[GitHub] [hudi] yanghua commented on a diff in pull request #6071: [HUDI-4065] Add FileBasedLockProvider

2022-07-15 Thread GitBox
yanghua commented on code in PR #6071: URL: https://github.com/apache/hudi/pull/6071#discussion_r922103787 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/FileSystemBasedLockProvider.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apach

[GitHub] [hudi] yanghua commented on a diff in pull request #6071: [HUDI-4065] Add FileBasedLockProvider

2022-07-14 Thread GitBox
yanghua commented on code in PR #6071: URL: https://github.com/apache/hudi/pull/6071#discussion_r920857571 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieLockConfig.java: ## @@ -108,6 +109,12 @@ public class HoodieLockConfig extends HoodieConfig {

[GitHub] [hudi] yanghua commented on a diff in pull request #6071: [HUDI-4065] Add FileBasedLockProvider

2022-07-14 Thread GitBox
yanghua commented on code in PR #6071: URL: https://github.com/apache/hudi/pull/6071#discussion_r920843519 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieLockConfig.java: ## @@ -108,6 +109,12 @@ public class HoodieLockConfig extends HoodieConfig {

[GitHub] [hudi] yanghua commented on a diff in pull request #6071: [HUDI-4065] Add FileBasedLockProvider

2022-07-13 Thread GitBox
yanghua commented on code in PR #6071: URL: https://github.com/apache/hudi/pull/6071#discussion_r920716531 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieLockConfig.java: ## @@ -108,6 +109,12 @@ public class HoodieLockConfig extends HoodieConfig {

[GitHub] [hudi] yanghua commented on a diff in pull request #6071: [HUDI-4065] Add FileBasedLockProvider

2022-07-13 Thread GitBox
yanghua commented on code in PR #6071: URL: https://github.com/apache/hudi/pull/6071#discussion_r920713165 ## hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/transaction/TestFileBasedLockProvider.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Softw