[GitHub] [hudi] yanghua commented on pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-15 Thread GitBox
yanghua commented on pull request #1827: URL: https://github.com/apache/hudi/pull/1827#issuecomment-692580624 +1 to turn to function API fashion and standard / reduce some API's behavior. We are verifying and discussing with @wangxianghu offline. --

[GitHub] [hudi] yanghua commented on pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-12 Thread GitBox
yanghua commented on pull request #1827: URL: https://github.com/apache/hudi/pull/1827#issuecomment-690922454 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hudi] yanghua commented on pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-12 Thread GitBox
yanghua commented on pull request #1827: URL: https://github.com/apache/hudi/pull/1827#issuecomment-690922454 @leesf Thanks for your awesome work. Can you squash these commits for the subsequent review? This is an automated

[GitHub] [hudi] yanghua commented on pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-11 Thread GitBox
yanghua commented on pull request #1827: URL: https://github.com/apache/hudi/pull/1827#issuecomment-690922454 @leesf Thanks for your awesome work. Can you squash these commits for the subsequent review? This is an automated