[GitHub] [hudi] yihua commented on a change in pull request #3727: [HUDI-2497] Refactor clean, restore, and compaction actions in hudi-client module

2021-09-30 Thread GitBox
yihua commented on a change in pull request #3727: URL: https://github.com/apache/hudi/pull/3727#discussion_r719758782 ## File path: hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/common/HoodieFlinkEngineContext.java ## @@ -68,6 +77,21 @@ public HoodieFlink

[GitHub] [hudi] yihua commented on a change in pull request #3727: [HUDI-2497] Refactor clean, restore, and compaction actions in hudi-client module

2021-09-30 Thread GitBox
yihua commented on a change in pull request #3727: URL: https://github.com/apache/hudi/pull/3727#discussion_r719752579 ## File path: hudi-common/src/main/java/org/apache/hudi/common/function/SerializablePairFlatMapFunction.java ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apach

[GitHub] [hudi] yihua commented on a change in pull request #3727: [HUDI-2497] Refactor clean, restore, and compaction actions in hudi-client module

2021-09-30 Thread GitBox
yihua commented on a change in pull request #3727: URL: https://github.com/apache/hudi/pull/3727#discussion_r719756887 ## File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/SparkRDDWriteClient.java ## @@ -321,15 +324,14 @@ protected void completeComp

[GitHub] [hudi] yihua commented on a change in pull request #3727: [HUDI-2497] Refactor clean, restore, and compaction actions in hudi-client module

2021-09-30 Thread GitBox
yihua commented on a change in pull request #3727: URL: https://github.com/apache/hudi/pull/3727#discussion_r719752579 ## File path: hudi-common/src/main/java/org/apache/hudi/common/function/SerializablePairFlatMapFunction.java ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apach

[GitHub] [hudi] yihua commented on a change in pull request #3727: [HUDI-2497] Refactor clean, restore, and compaction actions in hudi-client module

2021-09-30 Thread GitBox
yihua commented on a change in pull request #3727: URL: https://github.com/apache/hudi/pull/3727#discussion_r719752331 ## File path: hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/common/HoodieFlinkEngineContext.java ## @@ -86,6 +110,17 @@ public RuntimeCon

[GitHub] [hudi] yihua commented on a change in pull request #3727: [HUDI-2497] Refactor clean, restore, and compaction actions in hudi-client module

2021-09-30 Thread GitBox
yihua commented on a change in pull request #3727: URL: https://github.com/apache/hudi/pull/3727#discussion_r719751200 ## File path: hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/HoodieFlinkWriteClient.java ## @@ -369,7 +372,14 @@ public void completeCompa

[GitHub] [hudi] yihua commented on a change in pull request #3727: [HUDI-2497] Refactor clean, restore, and compaction actions in hudi-client module

2021-09-30 Thread GitBox
yihua commented on a change in pull request #3727: URL: https://github.com/apache/hudi/pull/3727#discussion_r719749416 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/CompactHelpers.java ## @@ -0,0 +1,178 @@ +/* + * Licensed to t