[GitHub] [hudi] yihua commented on a change in pull request #3746: [HUDI-2515] Add close when producing records failed

2021-10-26 Thread GitBox
yihua commented on a change in pull request #3746: URL: https://github.com/apache/hudi/pull/3746#discussion_r736983188 ## File path: hudi-common/src/main/java/org/apache/hudi/common/util/ParquetReaderIterator.java ## @@ -49,8 +49,9 @@ public boolean hasNext() { this.n

[GitHub] [hudi] yihua commented on a change in pull request #3746: [HUDI-2515] Add close when producing records failed

2021-10-25 Thread GitBox
yihua commented on a change in pull request #3746: URL: https://github.com/apache/hudi/pull/3746#discussion_r735750112 ## File path: hudi-common/src/test/java/org/apache/hudi/common/util/TestParquetReaderIterator.java ## @@ -59,6 +61,7 @@ public void testParquetIterator() thro

[GitHub] [hudi] yihua commented on a change in pull request #3746: [HUDI-2515] Add close when producing records failed

2021-10-22 Thread GitBox
yihua commented on a change in pull request #3746: URL: https://github.com/apache/hudi/pull/3746#discussion_r734653163 ## File path: hudi-common/src/test/java/org/apache/hudi/common/util/TestParquetReaderIterator.java ## @@ -59,6 +59,6 @@ public void testParquetIterator() thro

[GitHub] [hudi] yihua commented on a change in pull request #3746: [HUDI-2515] Add close when producing records failed

2021-10-21 Thread GitBox
yihua commented on a change in pull request #3746: URL: https://github.com/apache/hudi/pull/3746#discussion_r734243707 ## File path: hudi-common/src/main/java/org/apache/hudi/common/util/ParquetReaderIterator.java ## @@ -49,8 +50,13 @@ public boolean hasNext() { this.