[GitHub] [hudi] yihua commented on a diff in pull request #7921: [HUDI-5764] Roll back delta commits from `HoodieIndexer` lazily in metadata table

2023-02-10 Thread via GitHub
yihua commented on code in PR #7921: URL: https://github.com/apache/hudi/pull/7921#discussion_r1103502951 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -875,7 +879,11 @@ public void buildMetadataPartitions(Ho

[GitHub] [hudi] yihua commented on a diff in pull request #7921: [HUDI-5764] Roll back delta commits from `HoodieIndexer` lazily in metadata table

2023-02-10 Thread via GitHub
yihua commented on code in PR #7921: URL: https://github.com/apache/hudi/pull/7921#discussion_r1103501262 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -1125,7 +1130,10 @@ private void initialCommit(String cr

[GitHub] [hudi] yihua commented on a diff in pull request #7921: [HUDI-5764] Roll back delta commits from `HoodieIndexer` lazily in metadata table

2023-02-10 Thread via GitHub
yihua commented on code in PR #7921: URL: https://github.com/apache/hudi/pull/7921#discussion_r1103501151 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -875,7 +879,11 @@ public void buildMetadataPartitions(Ho

[GitHub] [hudi] yihua commented on a diff in pull request #7921: [HUDI-5764] Roll back delta commits from `HoodieIndexer` lazily in metadata table

2023-02-10 Thread via GitHub
yihua commented on code in PR #7921: URL: https://github.com/apache/hudi/pull/7921#discussion_r1103486098 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -1125,7 +1130,10 @@ private void initialCommit(String cr

[GitHub] [hudi] yihua commented on a diff in pull request #7921: [HUDI-5764] Roll back delta commits from `HoodieIndexer` lazily in metadata table

2023-02-10 Thread via GitHub
yihua commented on code in PR #7921: URL: https://github.com/apache/hudi/pull/7921#discussion_r1103483491 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java: ## @@ -659,8 +662,46 @@ protected Map> getPendingRollbackInfos

[GitHub] [hudi] yihua commented on a diff in pull request #7921: [HUDI-5764] Roll back delta commits from `HoodieIndexer` lazily in metadata table

2023-02-10 Thread via GitHub
yihua commented on code in PR #7921: URL: https://github.com/apache/hudi/pull/7921#discussion_r1103483348 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java: ## @@ -659,8 +662,46 @@ protected Map> getPendingRollbackInfos

[GitHub] [hudi] yihua commented on a diff in pull request #7921: [HUDI-5764] Roll back delta commits from `HoodieIndexer` lazily in metadata table

2023-02-10 Thread via GitHub
yihua commented on code in PR #7921: URL: https://github.com/apache/hudi/pull/7921#discussion_r1103472610 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java: ## @@ -1279,8 +1279,21 @@ protected void tryUpgrade(HoodieTableMetaClient